m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 12:29:06 +01:00
Code

Fix/handle safe low undefined (#10561)

Browse Source 
* fix: handle safeLow undefined

fixes #10558

* fix: add tests for isCustomGasPriceSafe selector
This commit is contained in:
Shane 2021-03-02 14:19:56 -08:00 committed by Brad Decker
parent 615f87e12e
commit d034adfb24
2 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/app/selectors/custom-gas.js
View File

@ -64,7 +64,7 @@ export function isCustomPriceSafe(state) {
return true;
}
if (safeLow === null) {
if (!safeLow) {
return false;
}

39
ui/app/selectors/tests/custom-gas.test.js
View File

@ -6,6 +6,7 @@ const {
getCustomGasPrice,
getRenderableBasicEstimateData,
getRenderableEstimateDataForSmallButtonsFromGWEI,
isCustomPriceSafe,
} = proxyquire('../custom-gas', {});
describe('custom-gas selectors', function () {
@ -15,6 +16,44 @@ describe('custom-gas selectors', function () {
assert.strictEqual(getCustomGasPrice(mockState), 'mockPrice');
});
});
describe('isCustomGasPriceSafe()', function () {
it('should return true for gas.customData.price 0x77359400', function () {
const mockState = {
gas: {
customData: { price: '0x77359400' },
basicEstimates: { safeLow: 1 },
},
};
assert.strictEqual(isCustomPriceSafe(mockState), true);
});
it('should return true for gas.customData.price null', function () {
const mockState = {
gas: {
customData: { price: null },
basicEstimates: { safeLow: 1 },
},
};
assert.strictEqual(isCustomPriceSafe(mockState), true);
});
it('should return true gas.customData.price undefined', function () {
const mockState = {
gas: {
customData: { price: undefined },
basicEstimates: { safeLow: 1 },
},
};
assert.strictEqual(isCustomPriceSafe(mockState), true);
});
it('should return false gas.basicEstimates.safeLow undefined', function () {
const mockState = {
gas: {
customData: { price: '0x77359400' },
basicEstimates: { safeLow: undefined },
},
};
assert.strictEqual(isCustomPriceSafe(mockState), false);
});
});
describe('getCustomGasLimit()', function () {
it('should return gas.customData.limit', function () {