Merge branch 'master' into fox-sub

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Current Master
 
+## 2.9.0 2016-08-22
+
 - Added ShapeShift to the transaction history
 - Added affiliate key to Shapeshift requests
 - Added feature to reflect current conversion rates of current vault balance.

app/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "MetaMask",
   "short_name": "Metamask",
-  "version": "2.8.0",
+  "version": "2.9.0",
   "manifest_version": 2,
   "description": "Ethereum Browser Extension",
   "icons": {

test/unit/util_test.js

@@ -156,7 +156,12 @@ describe('util', function() {
       var result = util.formatBalance(input)
       assert.equal(result, '0.00032 ETH')
     })
-
+    it('should not parse the balance and return value with 2 decimal points with ETH at the end', function() {
+      var value = '1.2456789'
+      var needsParse = false
+      var result = util.formatBalance(value, 2, needsParse)
+      assert.equal(result, '1.24 ETH')
+    })
   })
 
   describe('normalizing values', function() {

ui/app/components/eth-balance.js

@@ -15,8 +15,8 @@ function EthBalanceComponent () {
 EthBalanceComponent.prototype.render = function () {
   var state = this.props
   var style = state.style
-
+  var needsParse = this.props.needsParse !== undefined ? this.props.needsParse : true
-  const value = formatBalance(state.value, 6)
+  const value = formatBalance(state.value, 6, needsParse)
   var width = state.width
 
   return (
@@ -29,12 +29,13 @@ EthBalanceComponent.prototype.render = function () {
           display: 'inline',
           width: width,
         },
-      }, this.renderBalance(value, state)),
+      }, this.renderBalance(value)),
     ])
 
   )
 }
-EthBalanceComponent.prototype.renderBalance = function (value, state) {
+EthBalanceComponent.prototype.renderBalance = function (value) {
+  var state = this.props
   if (value === 'None') return value
   var balanceObj = generateBalanceObject(value, state.shorten ? 1 : 3)
   var balance
@@ -68,7 +69,7 @@ EthBalanceComponent.prototype.renderBalance = function (value, state) {
             width: '100%',
             textAlign: 'right',
           },
-        }, balance),
+        }, this.props.incoming ? `+${balance}` : balance),
         h('div', {
           style: {
             color: ' #AEAEAE',

ui/app/components/shift-list-item.js

@@ -99,6 +99,8 @@ ShiftListItem.prototype.renderUtilComponents = function () {
           value: `${props.response.outgoingCoin}`,
           width: '55px',
           shorten: true,
+          needsParse: false,
+          incoming: true,
           style: {
             fontSize: '15px',
             color: '#01888C',

ui/app/util.js

@@ -92,8 +92,8 @@ function parseBalance (balance) {
 
 // Takes wei hex, returns an object with three properties.
 // Its "formatted" property is what we generally use to render values.
-function formatBalance (balance, decimalsToKeep) {
+function formatBalance (balance, decimalsToKeep, needsParse = true) {
-  var parsed = parseBalance(balance)
+  var parsed = needsParse ? parseBalance(balance) : balance.split('.')
   var beforeDecimal = parsed[0]
   var afterDecimal = parsed[1]
   var formatted = 'None'