100% French locale, reordering of English locale, fixes #5457 (#5470)

* french locales: fix typos and improve wording

* french locales: more fixes and rewording

* fixed typo

* fixed typo

* added missing translations

* fixed alphabetical order

* fixed alphabetical order

* added missing translations for FR

* fixed verify-locale-strings.js

* fixed indentation

* fixed indentation

* updated french locale

* updated changelog with changes logs

* a few fixes after receiving comments, mostly Caps removing and adding

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Current Develop Branch
 
 - Update transaction statuses when switching networks.
+- [#5470](https://github.com/MetaMask/metamask-extension/pull/5470) 100% coverage in French locale, fixed the procedure to verify proposed locale.
 
 ## 4.12.0 Thursday September 27 2018
 

app/_locales/en/messages.json

@@ -3,7 +3,7 @@
     "message": "Accept"
   },
   "accessingYourCamera": {
-    "message": "Accesing your camera..."
+    "message": "Accessing your camera..."
   },
   "account": {
     "message": "Account"
@@ -167,6 +167,21 @@
   "connecting": {
     "message": "Connecting..."
   },
+  "connectingToKovan": {
+    "message": "Connecting to Kovan Test Network"
+  },
+  "connectingToMainnet": {
+    "message": "Connecting to Main Ethereum Network"
+  },
+  "connectingToRopsten": {
+    "message": "Connecting to Ropsten Test Network"
+  },
+  "connectingToRinkeby": {
+    "message": "Connecting to Rinkeby Test Network"
+  },
+  "connectingToUnknown": {
+    "message": "Connecting to Unknown Network"
+  },
   "connectToLedger": {
     "message": "Connect to Ledger"
   },
@@ -234,6 +249,9 @@
   "currentNetwork": {
     "message": "Current Network"
   },
+  "currentRpc": {
+    "message": "Current RPC"
+  },
   "customGas": {
     "message": "Customize Gas"
   },
@@ -340,15 +358,6 @@
   "enterPasswordContinue": {
     "message": "Enter password to continue"
   },
-  "parameters": {
-    "message": "Parameters"
-  },
-  "passwordNotLongEnough": {
-    "message": "Password not long enough"
-  },
-  "passwordsDontMatch": {
-    "message": "Passwords Don't Match"
-  },
   "etherscanView": {
     "message": "View account on Etherscan"
   },
@@ -504,6 +513,9 @@
   "importUsingSeed": {
     "message": "Import using account seed phrase"
   },
+  "info": {
+    "message": "Info"
+  },
   "infoHelp": {
     "message": "Info & Help"
   },
@@ -532,7 +544,7 @@
     "message": "Invalid Request"
   },
   "invalidRPC": {
-    "message": "Invalid RPC URI"
+    "message": "Invalid RPC URL"
   },
   "invalidSeedPhrase": {
     "message": "Invalid seed phrase"
@@ -656,6 +668,9 @@
   "newPassword": {
     "message": "New Password (min 8 chars)"
   },
+  "newPassword8Chars": {
+    "message": "New Password (min 8 chars)"
+  },
   "newRecipient": {
     "message": "New Recipient"
   },
@@ -698,6 +713,13 @@
   "oldUIMessage": {
     "message": "You have returned to the old UI. You can switch back to the New UI through the option in the top right dropdown menu."
   },
+  "onlySendToEtherAddress": {
+    "message": "Only send ETH to an Ethereum address."
+  },
+  "onlySendTokensToAccountAddress": {
+    "message": "Only send $1 to an Ethereum account address.",
+    "description": "displays token symbol"
+  },
   "openInTab": {
     "message": "Open in tab"
   },
@@ -705,9 +727,24 @@
     "message": "or",
     "description": "choice between creating or importing a new account"
   },
+  "orderOneHere": {
+    "message": "Order a Trezor or Ledger and keep your funds in cold storage"
+  },
   "origin": {
     "message": "Origin"
   },
+  "outgoing": {
+    "message": "Outgoing"
+  },
+  "parameters": {
+    "message": "Parameters"
+  },
+  "passwordNotLongEnough": {
+    "message": "Password not long enough"
+  },
+  "passwordsDontMatch": {
+    "message": "Passwords Don't Match"
+  },
   "password": {
     "message": "Password"
   },
@@ -865,24 +902,6 @@
   "rpc": {
     "message": "Custom RPC"
   },
-  "currentRpc": {
-    "message": "Current RPC"
-  },
-  "connectingToMainnet": {
-    "message": "Connecting to Main Ethereum Network"
-  },
-  "connectingToRopsten": {
-    "message": "Connecting to Ropsten Test Network"
-  },
-  "connectingToKovan": {
-    "message": "Connecting to Kovan Test Network"
-  },
-  "connectingToRinkeby": {
-    "message": "Connecting to Rinkeby Test Network"
-  },
-  "connectingToUnknown": {
-    "message": "Connecting to Unknown Network"
-  },
   "sampleAccountName": {
     "message": "E.g. My new account",
     "description": "Help user understand concept of adding a human-readable name to their account"
@@ -890,15 +909,6 @@
   "save": {
     "message": "Save"
   },
-  "speedUp": {
-    "message": "speed up"
-  },
-  "speedUpTitle": {
-    "message": "Speed Up Transaction"
-  },
-  "speedUpSubtitle": {
-    "message": "Increase your gas price to attempt to overwrite and speed up your transaction"
-  },
   "saveAsCsvFile": {
     "message": "Save as CSV File"
   },
@@ -909,6 +919,12 @@
   "saveSeedAsFile": {
     "message": "Save Seed Words As File"
   },
+  "scanInstructions": {
+    "message": "Place the QR code in front of your camera"
+  },
+  "scanQrCode": {
+    "message": "Scan QR Code"
+  },
   "search": {
     "message": "Search"
   },
@@ -918,15 +934,6 @@
   "secretPhrase": {
     "message": "Enter your secret twelve word phrase here to restore your vault."
   },
-  "showHexData": {
-    "message": "Show Hex Data"
-  },
-  "showHexDataDescription": {
-    "message": "Select this to show the hex data field on the send screen"
-  },
-  "newPassword8Chars": {
-    "message": "New Password (min 8 chars)"
-  },
   "seedPhraseReq": {
     "message": "Seed phrases are 12 words long"
   },
@@ -963,19 +970,6 @@
   "separateEachWord": {
     "message": "Separate each word with a single space"
   },
-  "onlySendToEtherAddress": {
-    "message": "Only send ETH to an Ethereum address."
-  },
-  "onlySendTokensToAccountAddress": {
-    "message": "Only send $1 to an Ethereum account address.",
-    "description": "displays token symbol"
-  },
-  "orderOneHere": {
-    "message": "Order a Trezor or Ledger and keep your funds in cold storage"
-  },
-  "outgoing": {
-    "message": "Outgoing"
-  },
   "searchTokens": {
     "message": "Search Tokens"
   },
@@ -1000,33 +994,6 @@
   "settings": {
     "message": "Settings"
   },
-  "step1HardwareWallet": {
-    "message": "1. Connect Hardware Wallet"
-  },
-  "step1HardwareWalletMsg": {
-    "message": "Connect your hardware wallet directly to your computer."
-  },
-  "step2HardwareWallet": {
-    "message": "2. Select an Account"
-  },
-  "step2HardwareWalletMsg": {
-    "message": "Select the account you want to view. You can only choose one at a time."
-  },
-  "step3HardwareWallet": {
-    "message": "3. Start using dApps and more!"
-  },
-  "step3HardwareWalletMsg": {
-    "message": "Use your hardware account like you would with any Ethereum account. Log in to dApps, send Eth, buy and store ERC20 tokens and Non-Fungible tokens like CryptoKitties."
-  },
-  "info": {
-  "message": "Info"
-  },
-  "scanInstructions": {
-    "message": "Place the QR code in front of your camera"
-  },
-  "scanQrCode": {
-    "message": "Scan QR Code"
-  },
   "shapeshiftBuy": {
     "message": "Buy with Shapeshift"
   },
@@ -1036,6 +1003,12 @@
   "showQRCode": {
     "message": "Show QR Code"
   },
+  "showHexData": {
+    "message": "Show Hex Data"
+  },
+  "showHexDataDescription": {
+    "message": "Select this to show the hex data field on the send screen"
+  },
   "sign": {
     "message": "Sign"
   },
@@ -1060,6 +1033,15 @@
   "spaceBetween": {
     "message": "there can only be a space between words"
   },
+  "speedUp": {
+    "message": "speed up"
+  },
+  "speedUpTitle": {
+    "message": "Speed Up Transaction"
+  },
+  "speedUpSubtitle": {
+    "message": "Increase your gas price to attempt to overwrite and speed up your transaction"
+  },
   "status": {
     "message": "Status"
   },
@@ -1072,6 +1054,24 @@
   "stateLogError": {
     "message": "Error in retrieving state logs."
   },
+  "step1HardwareWallet": {
+    "message": "1. Connect Hardware Wallet"
+  },
+  "step1HardwareWalletMsg": {
+    "message": "Connect your hardware wallet directly to your computer."
+  },
+  "step2HardwareWallet": {
+    "message": "2. Select an Account"
+  },
+  "step2HardwareWalletMsg": {
+    "message": "Select the account you want to view. You can only choose one at a time."
+  },
+  "step3HardwareWallet": {
+    "message": "3. Start using dApps and more!"
+  },
+  "step3HardwareWalletMsg": {
+    "message": "Use your hardware account like you would with any Ethereum account. Log in to dApps, send Eth, buy and store ERC20 tokens and Non-Fungible tokens like CryptoKitties."
+  },
   "submit": {
     "message": "Submit"
   },

development/verify-locale-strings.js

@@ -20,7 +20,7 @@ const specifiedLocale = process.argv[2]
 if (specifiedLocale) {
 	console.log(`Verifying selected locale "${specifiedLocale}":\n\n`)
 	const locale = localeIndex.find(localeMeta => localeMeta.code === specifiedLocale)
-	verifyLocale({ locale })
+	verifyLocale(locale)
 } else {
 	console.log('Verifying all locales:\n\n')
 	localeIndex.forEach(localeMeta => {
@@ -30,11 +30,10 @@ if (specifiedLocale) {
 }
 
 
-function verifyLocale ({ localeMeta }) {
+function verifyLocale (localeMeta) {
 	const localeCode = localeMeta.code
 	const localeName = localeMeta.name
 	let targetLocale, englishLocale
-
 	try {
 		const localeFilePath = path.join(process.cwd(), 'app', '_locales', localeCode, 'messages.json')
 		targetLocale = JSON.parse(fs.readFileSync(localeFilePath, 'utf8'))