From bda64ab132e87d4f717f257935a842f7368f0776 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Tue, 25 Oct 2016 14:58:04 -0700 Subject: [PATCH 1/2] Fix delegate call analysis Fixed reference allowing transactions to be analyzed for delegate call again. --- CHANGELOG.md | 1 + app/scripts/lib/idStore.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f2c442050..0586b8ef1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Current Master - Add a check for improper Transaction data. +- Fix bug that was sometimes preventing transactions from being sent. ## 2.13.5 2016-10-18 diff --git a/app/scripts/lib/idStore.js b/app/scripts/lib/idStore.js index 402a5e612..cb14a5145 100644 --- a/app/scripts/lib/idStore.js +++ b/app/scripts/lib/idStore.js @@ -247,7 +247,7 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone // perform static analyis on the target contract code function analyzeForDelegateCall(cb){ if (txParams.to) { - query.getCode(txParams.to, function (err, result) { + query.getCode(txParams.to, (err, result) => { if (err) return cb(err) var containsDelegateCall = this.checkForDelegateCall(result) txData.containsDelegateCall = containsDelegateCall From 21e73311115504aebb206a24f3084ee304157647 Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Tue, 25 Oct 2016 17:41:50 -0700 Subject: [PATCH 2/2] Fix delegate call function reference 2 --- app/scripts/lib/idStore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/scripts/lib/idStore.js b/app/scripts/lib/idStore.js index cb14a5145..27372b3e9 100644 --- a/app/scripts/lib/idStore.js +++ b/app/scripts/lib/idStore.js @@ -249,7 +249,7 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone if (txParams.to) { query.getCode(txParams.to, (err, result) => { if (err) return cb(err) - var containsDelegateCall = this.checkForDelegateCall(result) + var containsDelegateCall = self.checkForDelegateCall(result) txData.containsDelegateCall = containsDelegateCall cb() })