m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

move locale to properties (#9769)

Browse Source
This commit is contained in:
Brad Decker 2020-10-30 16:12:33 -05:00 committed by GitHub
parent 1a164cd3e4
commit c6064072c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
shared/modules/metametrics.js
View File

@ -72,7 +72,6 @@ export const segmentLegacy = process.env.SEGMENT_LEGACY_WRITE_KEY
* @property {string} app.name - the name of the application tracking the event * @property {string} app.name - the name of the application tracking the event
* @property {string} app.version - the version of the application * @property {string} app.version - the version of the application
* @property {string} userAgent - the useragent string of the user * @property {string} userAgent - the useragent string of the user
* @property {string} locale - the locale string for the user
* @property {Object} [page] - an object representing details of the current page * @property {Object} [page] - an object representing details of the current page
* @property {string} [page.path] - the path of the current page (e.g /home) * @property {string} [page.path] - the path of the current page (e.g /home)
* @property {string} [page.title] - the title of the current page (e.g 'home') * @property {string} [page.title] - the title of the current page (e.g 'home')
@ -186,7 +185,6 @@ export function getTrackMetaMetricsEvent (
name: 'MetaMask Extension', name: 'MetaMask Extension',
version, version,
}, },
locale,
userAgent: window.navigator.userAgent, userAgent: window.navigator.userAgent,
...pick(providedContext, ['page', 'referrer']), ...pick(providedContext, ['page', 'referrer']),
...pick(eventContext, ['page', 'referrer']), ...pick(eventContext, ['page', 'referrer']),
@ -198,13 +196,16 @@ export function getTrackMetaMetricsEvent (
// These values are omitted from properties because they have special meaning // These values are omitted from properties because they have special meaning
// in segment. https://segment.com/docs/connections/spec/track/#properties. // in segment. https://segment.com/docs/connections/spec/track/#properties.
// to avoid accidentally using these inappropriately, you must add them as top // to avoid accidentally using these inappropriately, you must add them as top
// level properties on the event payload. // level properties on the event payload. We also exclude locale to prevent consumers
...omit(properties, ['revenue', 'currency', 'value']), // from overwriting this context level property. We track it as a property
// because not all destinations map locale from context.
...omit(properties, ['revenue', 'locale', 'currency', 'value']),
revenue, revenue,
value, value,
currency, currency,
category, category,
network, network,
locale,
chain_id: chainId, chain_id: chainId,
environment_type: environmentType, environment_type: environmentType,
}, },