m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

EIP-1559 - Provide tooltip text for all advanced gas controls (#11529)

Browse Source
This commit is contained in:
David Walsh 2021-07-15 12:23:37 -05:00 committed by GitHub
parent 1e1530e8e9
commit c241d3150c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/_locales/en/messages.json
View File

@ -650,15 +650,24 @@
"editGasHigh": { "editGasHigh": {
"message": "High" "message": "High"
}, },
"editGasLimitTooltip": {
"message": "Gas limit is the maximum units of gas you are willing to use. Units of gas are a multiplier to “Max priority fee” and “Max fee”."
},
"editGasLow": { "editGasLow": {
"message": "Low" "message": "Low"
}, },
"editGasMaxFeeLow": { "editGasMaxFeeLow": {
"message": "Max fee too low for network conditions" "message": "Max fee too low for network conditions"
}, },
"editGasMaxFeeTooltip": {
"message": "The max fee is the most you’ll pay (base fee + priority fee)."
},
"editGasMaxPriorityFeeLow": { "editGasMaxPriorityFeeLow": {
"message": "Max priority fee too low for network conditions" "message": "Max priority fee too low for network conditions"
}, },
"editGasMaxPriorityFeeTooltip": {
"message": "Max priority fee (aka “miner tip”) goes directly to miners and incentivizes them to prioritize your transaction. You’ll most often pay your max setting"
},
"editGasMedium": { "editGasMedium": {
"message": "Medium" "message": "Medium"
}, },

6
ui/components/app/advanced-gas-controls/advanced-gas-controls.component.js
View File

@ -64,7 +64,7 @@ export default function AdvancedGasControls({
<FormField <FormField
titleText={t('gasLimit')} titleText={t('gasLimit')}
onChange={setGasLimit} onChange={setGasLimit}
tooltipText="" tooltipText={t('editGasLimitTooltip')}
value={gasLimit} value={gasLimit}
numeric numeric
autoFocus autoFocus
@ -74,7 +74,7 @@ export default function AdvancedGasControls({
<FormField <FormField
titleText={t('maxPriorityFee')} titleText={t('maxPriorityFee')}
titleUnit="(GWEI)" titleUnit="(GWEI)"
tooltipText="" tooltipText={t('editGasMaxPriorityFeeTooltip')}
onChange={(value) => { onChange={(value) => {
setMaxPriorityFee(value); setMaxPriorityFee(value);
onManualChange?.(); onManualChange?.();
@ -111,7 +111,7 @@ export default function AdvancedGasControls({
<FormField <FormField
titleText={t('maxFee')} titleText={t('maxFee')}
titleUnit="(GWEI)" titleUnit="(GWEI)"
tooltipText="" tooltipText={t('editGasMaxFeeTooltip')}
onChange={(value) => { onChange={(value) => {
setMaxFee(value); setMaxFee(value);
onManualChange?.(); onManualChange?.();