From 9f0ec1c18f80be51dceb55233b52878b20d86bbb Mon Sep 17 00:00:00 2001 From: Alex Donesky Date: Tue, 15 Jun 2021 13:17:38 -0500 Subject: [PATCH 1/3] patch breaking change in signTypeData param validation (#11309) --- app/scripts/lib/typed-message-manager.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/scripts/lib/typed-message-manager.js b/app/scripts/lib/typed-message-manager.js index 8e205520b..33bc80dd9 100644 --- a/app/scripts/lib/typed-message-manager.js +++ b/app/scripts/lib/typed-message-manager.js @@ -1,5 +1,5 @@ import EventEmitter from 'events'; -import { strict as assert } from 'assert'; +import assert from 'assert'; import { ObservableStore } from '@metamask/obs-store'; import { ethErrors } from 'eth-rpc-errors'; import { typedSignatureHash, TYPED_MESSAGE_SCHEMA } from 'eth-sig-util'; @@ -177,7 +177,7 @@ export default class TypedMessageManager extends EventEmitter { break; case 'V3': case 'V4': { - assert.equal( + assert.strictEqual( typeof params.data, 'string', '"params.data" must be a string.', @@ -191,7 +191,7 @@ export default class TypedMessageManager extends EventEmitter { data.primaryType in data.types, `Primary type of "${data.primaryType}" has no type definition.`, ); - assert.equal( + assert.strictEqual( validation.errors.length, 0, 'Signing data must conform to EIP-712 schema. See https://git.io/fNtcx.', From 56650b7e56d3dba54a79178474a6fde2066a8095 Mon Sep 17 00:00:00 2001 From: MetaMask Bot Date: Tue, 15 Jun 2021 18:59:27 +0000 Subject: [PATCH 2/3] Version v9.6.1 --- CHANGELOG.md | 7 ++++++- package.json | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0beaab857..09822d7d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [9.6.1] +### Uncategorized +- [#11309](https://github.com/MetaMask/metamask-extension/pull/11309): patch breaking change in signTypeData param validation + ## [9.6.0] ### Added - [#10905](https://github.com/MetaMask/metamask-extension/pull/10905): Implemented basic switchEthereumChain feature @@ -2297,7 +2301,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Uncategorized - Added the ability to restore accounts from seed words. -[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v9.6.0...HEAD +[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v9.6.1...HEAD +[9.6.1]: https://github.com/MetaMask/metamask-extension/compare/v9.6.0...v9.6.1 [9.6.0]: https://github.com/MetaMask/metamask-extension/compare/v9.5.9...v9.6.0 [9.5.9]: https://github.com/MetaMask/metamask-extension/compare/v9.5.8...v9.5.9 [9.5.8]: https://github.com/MetaMask/metamask-extension/compare/v9.5.7...v9.5.8 diff --git a/package.json b/package.json index 6d51d1787..3a2c01b76 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask-crx", - "version": "9.6.0", + "version": "9.6.1", "private": true, "repository": { "type": "git", From 88c1342e6b640393740335d8043b9b409a9bc978 Mon Sep 17 00:00:00 2001 From: ryanml Date: Tue, 15 Jun 2021 12:42:02 -0700 Subject: [PATCH 3/3] [skip e2e] Update changelog for v9.6.1 (#11312) --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 09822d7d3..fe938d84f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,8 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ## [9.6.1] -### Uncategorized -- [#11309](https://github.com/MetaMask/metamask-extension/pull/11309): patch breaking change in signTypeData param validation +### Fixed +- [#11309](https://github.com/MetaMask/metamask-extension/pull/11309): Fixed signTypeData parameter validation issue ## [9.6.0] ### Added