m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Merge pull request #2259 from MetaMask/tx-history-fix

Browse Source 
tx state history - fix bug where initial snapshot was mutated on updateTx
This commit is contained in:
Frankie 2017-10-02 13:41:56 -07:00 committed by GitHub
commit bf390bd63d
3 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/scripts/lib/tx-state-history-helper.js
View File

@ -24,7 +24,8 @@ function generateHistoryEntry(previousState, newState) {
return jsonDiffer.compare(previousState, newState)
}
function replayHistory(shortHistory) {
function replayHistory(_shortHistory) {
const shortHistory = clone(_shortHistory)
return shortHistory.reduce((val, entry) => jsonDiffer.applyPatch(val, entry).newDocument)
}

2
app/scripts/lib/tx-state-manager.js
View File

@ -97,7 +97,7 @@ module.exports = class TransactionStateManger extends EventEmitter {
const previousState = txStateHistoryHelper.replayHistory(txMeta.history)
// generate history entry and add to history
const entry = txStateHistoryHelper.generateHistoryEntry(previousState, currentState)
txMeta.history.push(entry)
txMeta.history.push(entry)
// commit txMeta to state
const txId = txMeta.id

22
test/unit/tx-state-history-helper.js
View File

@ -20,4 +20,26 @@ describe('tx-state-history-helper', function () {
})
})
})
it('replaying history does not mutate the original obj', function () {
const initialState = { test: true, message: 'hello', value: 1 }
const diff1 = {
"op": "replace",
"path": "/message",
"value": "haay",
}
const diff2 = {
"op": "replace",
"path": "/value",
"value": 2,
}
const history = [initialState, diff1, diff2]
const beforeStateSnapshot = JSON.stringify(initialState)
const latestState = txStateHistoryHelper.replayHistory(history)
const afterStateSnapshot = JSON.stringify(initialState)
assert.notEqual(initialState, latestState, 'initial state is not the same obj as the latest state')
assert.equal(beforeStateSnapshot, afterStateSnapshot, 'initial state is not modified during run')
})
})