m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00
Code

Fix snap e2e tests (#13912)

Browse Source 
The snap e2e tests introduced in #13671 were broken due to a conflict
with the changes in #13895. The latter PR changed the version name for
non-main builds so that it always includes the build type.

The Firefox webdriver has been updated to use the new `getVersion`
utility, ensuring that it always looks for the correct build filename.
This commit is contained in:
Mark Stacey 2022-03-10 20:36:21 -03:30 committed by GitHub
parent 1f55af3151
commit bcf59ab09b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/webdriver/firefox.js
View File

@ -4,7 +4,8 @@ const path = require('path');
const { Builder, By, until } = require('selenium-webdriver'); const { Builder, By, until } = require('selenium-webdriver');
const firefox = require('selenium-webdriver/firefox'); const firefox = require('selenium-webdriver/firefox');
const proxy = require('selenium-webdriver/proxy'); const proxy = require('selenium-webdriver/proxy');
const { version } = require('../../../package.json'); const { getVersion } = require('../../../development/lib/get-version');
const { BuildType } = require('../../../development/lib/build-type');
/** /**
* The prefix for temporary Firefox profiles. All Firefox profiles used for e2e tests * The prefix for temporary Firefox profiles. All Firefox profiles used for e2e tests
@ -49,6 +50,7 @@ class FirefoxDriver {
const driver = builder.build(); const driver = builder.build();
const fxDriver = new FirefoxDriver(driver); const fxDriver = new FirefoxDriver(driver);
const version = getVersion(type || BuildType.main, 0);
let extensionString = `builds/metamask-firefox-${version}.zip`; let extensionString = `builds/metamask-firefox-${version}.zip`;
if (type) { if (type) {