1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00

Hide zero balance tokens at useTokenTracker layer (#10630)

This commit is contained in:
David Walsh 2021-03-11 12:07:41 -06:00 committed by Mark Stacey
parent e4d1f874f8
commit bcd04cdd93
3 changed files with 19 additions and 18 deletions

View File

@ -10,10 +10,7 @@ import {
getAssetImages,
getShouldHideZeroBalanceTokens,
} from '../../../selectors';
import {
getTokens,
getTokensWithBalance,
} from '../../../ducks/metamask/metamask';
import { getTokens } from '../../../ducks/metamask/metamask';
export default function TokenList({ onTokenClick }) {
const t = useI18nContext();
@ -25,13 +22,11 @@ export default function TokenList({ onTokenClick }) {
// from the background so it has a new reference with each background update,
// even if the tokens haven't changed
const tokens = useSelector(getTokens, isEqual);
const tokensWithBalance = useSelector(getTokensWithBalance, isEqual);
const { loading, tokensWithBalances } = useTokenTracker(
shouldHideZeroBalanceTokens ? tokensWithBalance : tokens,
tokens,
true,
shouldHideZeroBalanceTokens,
);
if (loading) {
return (
<div

View File

@ -386,6 +386,3 @@ export const getUnconnectedAccountAlertShown = (state) =>
state.metamask.unconnectedAccountAlertShownOrigins;
export const getTokens = (state) => state.metamask.tokens;
export const getTokensWithBalance = (state) =>
state.metamask.tokens.filter((token) => Number(token.balance) > 0);

View File

@ -4,21 +4,30 @@ import { useSelector } from 'react-redux';
import { getCurrentNetwork, getSelectedAddress } from '../selectors';
import { useEqualityCheck } from './useEqualityCheck';
export function useTokenTracker(tokens, includeFailedTokens = false) {
export function useTokenTracker(
tokens,
includeFailedTokens = false,
hideZeroBalanceTokens = false,
) {
const network = useSelector(getCurrentNetwork);
const userAddress = useSelector(getSelectedAddress);
const [loading, setLoading] = useState(() => tokens?.length >= 0);
const [tokensWithBalances, setTokensWithBalances] = useState([]);
const [error, setError] = useState(null);
const tokenTracker = useRef(null);
const memoizedTokens = useEqualityCheck(tokens);
const updateBalances = useCallback((tokenWithBalances) => {
setTokensWithBalances(tokenWithBalances);
setLoading(false);
setError(null);
}, []);
const updateBalances = useCallback(
(tokenWithBalances) => {
const matchingTokens = hideZeroBalanceTokens
? tokenWithBalances.filter((token) => Number(token.balance) > 0)
: tokenWithBalances;
setTokensWithBalances(matchingTokens);
setLoading(false);
setError(null);
},
[hideZeroBalanceTokens],
);
const showError = useCallback((err) => {
setError(err);