From ba98edf604a1344a5acacdbc0aaefbbc6c93ba60 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 2 Dec 2020 17:27:42 -0330 Subject: [PATCH] Remove unnecessary assertion in e2e metrics test (#9974) The assertion ensuring that there were at least 3 metrics received didn't end up being useful. If this assertion fails, it doesn't explain what segment events _were_ received. By removing this assertion and letting the later assertions catch this case, we at least learn which of the three expected events were present. --- test/e2e/metrics.spec.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/e2e/metrics.spec.js b/test/e2e/metrics.spec.js index e8598b792..ceca2cb64 100644 --- a/test/e2e/metrics.spec.js +++ b/test/e2e/metrics.spec.js @@ -35,10 +35,6 @@ describe('Segment metrics', function () { await driver.findElement(By.css('[data-testid="eth-overview-send"]')) assert.ok(segmentSpy.called, 'Segment should receive metrics') - assert.ok( - segmentSpy.callCount >= 3, - 'At least 3 segment events should be sent', - ) const firstSegmentEvent = segmentSpy.getCall(0).args[0] assert.equal(firstSegmentEvent.name, 'Home')