From ba25ad4073b4631df232fd02bf691b7acae3c8d4 Mon Sep 17 00:00:00 2001 From: Jyoti Puri Date: Tue, 29 Nov 2022 22:34:11 +0530 Subject: [PATCH] Not use hardware keyring classes when initializing KeyringController in extension MV3 version (#16684) --- app/scripts/metamask-controller.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 8e738f712..dee48bb68 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -585,12 +585,15 @@ export default class MetamaskController extends EventEmitter { await opts.openPopup(); }); - const additionalKeyrings = [ - TrezorKeyring, - LedgerBridgeKeyring, - LatticeKeyring, - QRHardwareKeyring, - ]; + let additionalKeyrings = []; + if (!isManifestV3) { + additionalKeyrings = [ + TrezorKeyring, + LedgerBridgeKeyring, + LatticeKeyring, + QRHardwareKeyring, + ]; + } this.keyringController = new KeyringController({ keyringTypes: additionalKeyrings, initState: initState.KeyringController,