m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Code

Fix unbound metrics track function (#10016)

Browse Source 
The new metrics controller has a `trackEvent` function that was being
called unbound, so `this` references were undefined. It is now bound
early in both places where it is passed in as a parameter.
This commit is contained in:
Mark Stacey 2020-12-08 12:40:55 -03:30
parent 01c0775486
commit b75863dc00
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/scripts/metamask-controller.js
View File

@ -287,7 +287,9 @@ export default class MetamaskController extends EventEmitter {
), ),
provider: this.provider, provider: this.provider,
blockTracker: this.blockTracker, blockTracker: this.blockTracker,
trackMetaMetricsEvent: this.metaMetricsController.trackEvent, trackMetaMetricsEvent: this.metaMetricsController.trackEvent.bind(
this.metaMetricsController,
),
getParticipateInMetrics: () => getParticipateInMetrics: () =>
this.metaMetricsController.state.participateInMetaMetrics, this.metaMetricsController.state.participateInMetaMetrics,
}) })
@ -1969,7 +1971,9 @@ export default class MetamaskController extends EventEmitter {
engine.push( engine.push(
createMethodMiddleware({ createMethodMiddleware({
origin, origin,
sendMetrics: this.metaMetricsController.trackEvent, sendMetrics: this.metaMetricsController.trackEvent.bind(
this.metaMetricsController,
),
handleWatchAssetRequest: this.preferencesController.requestWatchAsset.bind( handleWatchAssetRequest: this.preferencesController.requestWatchAsset.bind(
this.preferencesController, this.preferencesController,
), ),