1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 18:00:18 +01:00

Isolate container component, add refactor notes

This commit is contained in:
sdtsui 2017-08-02 21:53:40 -07:00
parent 41250f9769
commit b70a399faa
2 changed files with 57 additions and 19 deletions

View File

@ -0,0 +1,39 @@
const Component = require('react').Component
const h = require('react-hyperscript')
const inherits = require('util').inherits
// Main Views
const TxView = require('./components/tx-view')
const WalletView = require('./components/wallet-view')
module.exports = AccountAndTransactionDetails
inherits(AccountAndTransactionDetails, Component)
function AccountAndTransactionDetails () {
Component.call(this)
}
AccountAndTransactionDetails.prototype.render = function () {
console.log('atdR')
return h('div', {
style: {
display: 'flex',
flex: '1 0 auto',
},
}, [
// wallet
h(WalletView, {
style: {
},
responsiveDisplayClassname: '.lap-visible',
}, [
]),
// transaction
h(TxView, {
style: {
}
}, [
]),
])
}

View File

@ -4,6 +4,7 @@ const inherits = require('util').inherits
const TxView = require('./components/tx-view')
const WalletView = require('./components/wallet-view')
const SlideoutMenu = require('react-burger-menu').slide
const AccountAndTransactionDetails = require('./account-and-transaction-details')
module.exports = MainContainer
@ -14,6 +15,22 @@ function MainContainer () {
MainContainer.prototype.render = function () {
// 1. Fixing Mobile View: flush container
// media query for mobile view:
// position: absolute;
// margin-top: 35px;
// width: 100%;
//
// 2. Fix responsive sizing - smaller
// https://puu.sh/x0gDA/5ff3b734eb.png
//
// 3. summarize:
// switch statement goes inside MainContainer,
// or a method in renderPrimary
// - pass resulting h() to MainContainer
// - error checking in separate func
// - router in separate func
return h('div', {
style: {
position: 'absolute',
@ -27,24 +44,6 @@ MainContainer.prototype.render = function () {
alignItems: 'stretch',
overflowY: 'scroll',
}
}, [
h(WalletView, {
style: {
},
responsiveDisplayClassname: '.lap-visible',
}, [
]),
h(TxView, {
style: {
// flexGrow: 2
// width: '66.66%',
// height: '82vh',
// background: '#FFFFFF',
}
}, [
]),
])
}, [h(AccountAndTransactionDetails, {}, [])])
}