m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix #16804 - Onboarding - Prevent odd behavior with clicks and show/hide password (#16878)

Browse Source
This commit is contained in:
David Walsh 2022-12-12 08:36:02 -06:00 committed by seaona
parent 4e272beb26
commit b40fd429fb
3 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ui/components/ui/form-field/form-field.js
View File

@ -89,7 +89,6 @@ export default function FormField({
<Box <Box
className="form-field__heading-detail" className="form-field__heading-detail"
textAlign={TEXT_ALIGN.END} textAlign={TEXT_ALIGN.END}
marginBottom={3}
marginRight={2} marginRight={2}
{...titleDetailWrapperProps} {...titleDetailWrapperProps}
> >

22
ui/pages/onboarding-flow/create-password/create-password.js
View File

@ -182,16 +182,18 @@ export default function CreatePassword({
titleText={t('newPassword')} titleText={t('newPassword')}
value={password} value={password}
titleDetail={ titleDetail={
<button <Typography variant={TYPOGRAPHY.H7}>
className="create-password__form--password-button" <a
type="button" href=""
onClick={(e) => { className="create-password__form--password-button"
e.preventDefault(); onClick={(e) => {
setShowPassword(!showPassword); e.preventDefault();
}} setShowPassword(!showPassword);
> }}
{showPassword ? t('hide') : t('show')} >
</button> {showPassword ? t('hide') : t('show')}
</a>
</Typography>
} }
/> />
<FormField <FormField

3
ui/pages/onboarding-flow/create-password/index.scss
View File

@ -28,8 +28,7 @@
} }
&--password-button { &--password-button {
background-color: transparent; color: var(--color-primary-default);
color: var(--color-text-default);
} }
&--checkmark { &--checkmark {