m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix node/no-callback-literal issues (#9668)

Browse Source 
Refs #9663

See [`node/no-callback-literal`][1] for more information.

This change enables `node/no-callback-literal` and fixes the issues raised by the rule.

  [1]:https://github.com/mysticatea/eslint-plugin-node/blob/v11.1.0/docs/rules/no-callback-literal.md
This commit is contained in:
Whymarrh Whitby 2020-10-21 15:54:51 -02:30 committed by GitHub
parent 7d0a7ab301
commit b369a68eb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -98,7 +98,6 @@ module.exports = {
'node/no-path-concat': 'off', 'node/no-path-concat': 'off',
'dot-notation': 'off', 'dot-notation': 'off',
'mocha/max-top-level-suites': 'off', 'mocha/max-top-level-suites': 'off',
'node/no-callback-literal': 'off',
}, },
overrides: [{ overrides: [{

5
test/e2e/helpers.js
View File

@ -10,7 +10,7 @@ const largeDelayMs = regularDelayMs * 2
const dappPort = 8080 const dappPort = 8080
async function withFixtures (options, callback) { async function withFixtures (options, testSuite) {
const { dapp, fixtures, ganacheOptions, driverOptions, title } = options const { dapp, fixtures, ganacheOptions, driverOptions, title } = options
const fixtureServer = new FixtureServer() const fixtureServer = new FixtureServer()
const ganacheServer = new Ganache() const ganacheServer = new Ganache()
@ -33,8 +33,7 @@ async function withFixtures (options, callback) {
const { driver } = await buildWebDriver(driverOptions) const { driver } = await buildWebDriver(driverOptions)
webDriver = driver webDriver = driver
// eslint-disable-next-line node/callback-return,node/no-callback-literal await testSuite({
await callback({
driver, driver,
}) })