m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-22 17:33:23 +01:00
Code

Prevent Browserify error from being swallowed (#13647)

Browse Source 
If an error occurs while running Browserify, the stream that Browserify
creates will emit an `error` event. However, this event is not being
handled, so Node will catch it instead. But the error message it
produces is very nebulous, as it merely spits out the stream object and
completely ignores the actual error that occurred. So this commit
listens for the `error` event and outputs the error.

One note here is that when we are outputting the error, we must get
around a bug that exists in Endo where if you pass an Error object to
`console.{log,error,info,debug}` then you will just see `{}` on-screen.
We get around this by printing `err.stack`.
This commit is contained in:
Elliot Winkler 2022-02-17 13:47:50 -07:00 committed by GitHub
parent ef3199ebd1
commit b1b4e64ad0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
development/build/scripts.js
View File

@ -507,7 +507,7 @@ function createFactoredBuild({
}
});
await bundleIt(buildConfiguration);
await bundleIt(buildConfiguration, { reloadOnChange });
};
}
@ -572,7 +572,7 @@ function createNormalBundle({
});
});
await bundleIt(buildConfiguration);
await bundleIt(buildConfiguration, { reloadOnChange });
};
}
@ -720,7 +720,7 @@ function setupSourcemaps(buildConfiguration, { devMode }) {
});
}
async function bundleIt(buildConfiguration) {
async function bundleIt(buildConfiguration, { reloadOnChange }) {
const { label, bundlerOpts, events } = buildConfiguration;
const bundler = browserify(bundlerOpts);
@ -759,6 +759,13 @@ async function bundleIt(buildConfiguration) {
[],
]);
const bundleStream = bundler.bundle();
if (!reloadOnChange) {
bundleStream.on('error', (error) => {
console.error('Bundling failed! See details below.');
console.error(error.stack || error);
process.exit(1);
});
}
// trigger build pipeline instrumentations
events.emit('configurePipeline', { pipeline, bundleStream });
// start bundle, send into pipeline