PR 5575 review comment fixes

app/scripts/lib/buy-eth-url.js

@@ -11,28 +11,29 @@ module.exports = getBuyEthUrl
  * network does not match any of the specified cases, or if no network is given, returns undefined.
  *
  */
-function getBuyEthUrl ({ network, amount, address }) {
+function getBuyEthUrl({ network, amount, address, service }) {
-  let url
+	let url
-  switch (network) {
+	if (typeof network !== 'undefined') {
-    case '1':
+  	switch (network) {
-      url = `https://buy.coinbase.com/?code=9ec56d01-7e81-5017-930c-513daa27bb6a&amount=${amount}&address=${address}&crypto_currency=ETH`
+  		case '1':
-      break
+  			url = `https://buy.coinbase.com/?code=9ec56d01-7e81-5017-930c-513daa27bb6a&amount=${amount}&address=${address}&crypto_currency=ETH`
-
+  			break
-    case '3':
+  		case '3':
-      url = 'https://faucet.metamask.io/'
+  			url = 'https://faucet.metamask.io/'
-      break
+  			break
-
+  		case '4':
-    case '4':
+  			url = 'https://www.rinkeby.io/'
-      url = 'https://www.rinkeby.io/'
+  			break
-      break
+  		case '42':
-
+  			url = 'https://github.com/kovan-testnet/faucet'
-    case '42':
+  			break
-      url = 'https://github.com/kovan-testnet/faucet'
+  	}
-      break
+  } else {
-
+  	switch (service) {
-    case '5':
+  		case 'coinswitch':
-      url = `https://metamask.coinswitch.co/?address=${address}&to=eth`
+  			url = `https://metamask.coinswitch.co/?address=${address}&to=eth`
-      break
+  			break
+  	}
   }
-  return url
+	return url
 }

ui/app/components/modals/deposit-ether-modal.js

@@ -32,7 +32,7 @@ function mapDispatchToProps (dispatch) {
       dispatch(actions.buyEth({ network: '1', address, amount: 0 }))
     },
     toCoinSwitch: (address) => {
-      dispatch(actions.buyEth({ network: '5', address, amount: 0 }))
+      dispatch(actions.buyEth({ service: 'coinswitch', address, amount: 0 }))
     },
     hideModal: () => {
       dispatch(actions.hideModal())