m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

ConfirmPage: update setApprovalForAll dialog copy (#15744)

Browse Source 
* ConfirmPage: update setApprovalForAll copy

* ConfirmPage: add TODO issue link
This commit is contained in:
Ariella Vu 2022-09-08 18:17:40 +08:00 committed by GitHub
parent 838cd5b38c
commit a7ff6593a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/_locales/en/messages.json generated
View File

@ -606,7 +606,14 @@
"message": "Confirm"
},
"confirmPageDialogSetApprovalForAll": {
"message": "By clicking approve, you are granting access to all of the NFTs you currently own on this contract and any NFTs on this contract you may acquire in the future until you revoke this approval. The party to whom you're granting approval will be able to transfer your NFTs from your wallet without further notice. Proceed with caution."
"message": "You're granting access to $1, including any you might own in the future. The party on the other end can transfer NFTs from your wallet at any time without asking you until you revoke this approval. $2",
"description": "$1 and $2 are bolded translations 'confirmPageDialogSetApprovalForAllPlaceholder1' and 'confirmPageDialogSetApprovalForAllPlaceholder2'"
},
"confirmPageDialogSetApprovalForAllPlaceholder1": {
"message": "all the NFTs on this contract"
},
"confirmPageDialogSetApprovalForAllPlaceholder2": {
"message": "Proceed with caution."
},
"confirmPassword": {
"message": "Confirm password"

19
ui/components/app/confirm-page-container/confirm-page-container.component.js
View File

@ -308,7 +308,24 @@ export default class ConfirmPageContainer extends Component {
)}
{isSetApproveForAll && (
<Dialog type="error" className="confirm-page-container__dialog">
{t('confirmPageDialogSetApprovalForAll')}
{/*
TODO: https://github.com/MetaMask/metamask-extension/issues/15745
style={{ fontWeight: 'bold' }} because reset.scss removes font-weight from b. We should fix this.
*/}
{t('confirmPageDialogSetApprovalForAll', [
<b
key="confirm-page-container__dialog-placeholder-1"
style={{ fontWeight: 'bold' }}
>
{t('confirmPageDialogSetApprovalForAllPlaceholder1')}
</b>,
<b
key="confirm-page-container__dialog-placeholder-2"
style={{ fontWeight: 'bold' }}
>
{t('confirmPageDialogSetApprovalForAllPlaceholder2')}
</b>,
])}
</Dialog>
)}
{contentComponent && (