m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 19:26:13 +02:00
Code

notices - markAllNoticesRead - use async/await

Browse Source
This commit is contained in:
kumavis 2019-03-29 12:03:31 +08:00
parent 781a39c039
commit a64855ef49
4 changed files with 16 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/scripts/metamask-controller.js
View File

@ -473,7 +473,7 @@ module.exports = class MetamaskController extends EventEmitter {
// notices
checkNotices: noticeController.updateNoticesList.bind(noticeController),
markNoticeRead: noticeController.markNoticeRead.bind(noticeController),
markAllNoticesRead: noticeController.markAllNoticesRead.bind(noticeController),
markAllNoticesRead: nodeify(noticeController.markAllNoticesRead, noticeController),
approveProviderRequest: providerApprovalController.approveProviderRequest.bind(providerApprovalController),
clearApprovedOrigins: providerApprovalController.clearApprovedOrigins.bind(providerApprovalController),

23
app/scripts/notice-controller.js
View File

@ -58,20 +58,15 @@ module.exports = class NoticeController extends EventEmitter {
}
}
markAllNoticesRead (cb) {
cb = cb || function (err) { if (err) throw err }
try {
const noticeList = this.getNoticesList()
noticeList.forEach(notice => {
notice.read = true
notice.body = ''
})
this.setNoticesList(noticeList)
const latestNotice = this.getNextUnreadNotice()
cb(null, latestNotice)
} catch (err) {
cb(err)
}
async markAllNoticesRead () {
const noticeList = this.getNoticesList()
noticeList.forEach(notice => {
notice.read = true
notice.body = ''
})
this.setNoticesList(noticeList)
const latestNotice = this.getNextUnreadNotice()
return latestNotice
}

5
test/unit/app/controllers/notice-controller-test.js
View File

@ -40,7 +40,7 @@ describe('notice-controller', function () {
})
describe('#markAllNoticesRead', () => {
it('marks all notices read', (done) => {
it('marks all notices read', async () => {
const testList = [{
id: 0,
read: false,
@ -57,11 +57,10 @@ describe('notice-controller', function () {
noticeController.setNoticesList(testList)
noticeController.markAllNoticesRead()
await noticeController.markAllNoticesRead()
const unreadNotices = noticeController.getUnreadNotices()
assert.equal(unreadNotices.length, 0)
done()
})
})

11
test/unit/ui/app/actions.spec.js
View File

@ -1321,14 +1321,11 @@ describe('Actions', () => {
completeOnboardingSpy.restore()
})
it('', (done) => {
it('completing onboarding marks all notices as read', async () => {
const store = mockStore()
store.dispatch(actions.setCompletedOnboarding())
.then(() => {
assert.equal(markAllNoticesReadSpy.callCount, 1)
assert.equal(completeOnboardingSpy.callCount, 1)
})
done()
await store.dispatch(actions.setCompletedOnboarding())
assert.equal(markAllNoticesReadSpy.callCount, 1)
assert.equal(completeOnboardingSpy.callCount, 1)
})
})