m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 01:39:44 +01:00
Code

Swaps: Add anonymized tracking for HW wallet and HW wallet type (#11063)

Browse Source
This commit is contained in:
Daniel 2021-05-12 17:17:17 +02:00 committed by GitHub
parent 3b335b3c74
commit a34f579484
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/data/mock-state.json
View File

@ -15,6 +15,12 @@
"provider": {
"chainId": "0x4"
},
"keyrings": [
{
"type": "Ledger Hardware",
"accounts": ["0x0dcd5d886577d5081b0c52e242ef29e70be3e7bc"]
}
],
"identities": {
"0x0dcd5d886577d5081b0c52e242ef29e70be3e7bc": {
"address": "0x0dcd5d886577d5081b0c52e242ef29e70be3e7bc",

7
ui/ducks/swaps/swaps.js
View File

@ -54,6 +54,7 @@ import {
getSwapsDefaultToken,
getCurrentChainId,
isHardwareWallet,
getHardwareWalletType,
} from '../../selectors';
import {
ERROR_FETCHING_QUOTES,
@ -483,6 +484,8 @@ export const fetchQuotesAndSetQuoteState = (
dispatch(setFromToken(selectedFromToken));
const hardwareWalletUsed = isHardwareWallet(state);
const hardwareWalletType = getHardwareWalletType(state);
metaMetricsEvent({
event: 'Quotes Requested',
category: 'swaps',
@ -493,6 +496,8 @@ export const fetchQuotesAndSetQuoteState = (
request_type: balanceError ? 'Quote' : 'Order',
slippage: maxSlippage,
custom_slippage: maxSlippage !== 2,
is_hardware_wallet: hardwareWalletUsed,
hardware_wallet_type: hardwareWalletType,
anonymizedData: true,
},
});
@ -563,6 +568,8 @@ export const fetchQuotesAndSetQuoteState = (
response_time: Date.now() - fetchStartTime,
best_quote_source: newSelectedQuote.aggregator,
available_quotes: Object.values(fetchedQuotes)?.length,
is_hardware_wallet: hardwareWalletUsed,
hardware_wallet_type: hardwareWalletType,
anonymizedData: true,
},
});

10
ui/selectors/selectors.js
View File

@ -88,6 +88,16 @@ export function isHardwareWallet(state) {
return keyring.type.includes('Hardware');
}
/**
* Get a HW wallet type, e.g. "Ledger Hardware"
* @param {Object} state
* @returns {String|undefined}
*/
export function getHardwareWalletType(state) {
const keyring = getCurrentKeyring(state);
return keyring.type.includes('Hardware') ? keyring.type : undefined;
}
export function getAccountType(state) {
const currentKeyring = getCurrentKeyring(state);
const type = currentKeyring && currentKeyring.type;

38
ui/selectors/selectors.test.js
View File

@ -15,6 +15,44 @@ describe('Selectors', () => {
});
});
describe('#isHardwareWallet', () => {
it('returns false if it is not a HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Simple Key Pair';
expect(selectors.isHardwareWallet(mockState)).toBe(false);
});
it('returns true if it is a Ledger HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Ledger Hardware';
expect(selectors.isHardwareWallet(mockState)).toBe(true);
});
it('returns true if it is a Trezor HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Trezor Hardware';
expect(selectors.isHardwareWallet(mockState)).toBe(true);
});
});
describe('#getHardwareWalletType', () => {
it('returns undefined if it is not a HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Simple Key Pair';
expect(selectors.getHardwareWalletType(mockState)).toBeUndefined();
});
it('returns "Ledger Hardware" if it is a Ledger HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Ledger Hardware';
expect(selectors.getHardwareWalletType(mockState)).toBe(
'Ledger Hardware',
);
});
it('returns "Trezor Hardware" if it is a Trezor HW wallet', () => {
mockState.metamask.keyrings[0].type = 'Trezor Hardware';
expect(selectors.getHardwareWalletType(mockState)).toBe(
'Trezor Hardware',
);
});
});
it('returns selected identity', () => {
expect(selectors.getSelectedIdentity(mockState)).toStrictEqual({
address: '0x0dcd5d886577d5081b0c52e242ef29e70be3e7bc',