m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fixing Speed up/Cancel information text (#14551)

Browse Source 
* Fixing Speed up/Cancel information text

* Adding tests
This commit is contained in:
ryanml 2022-05-09 08:37:31 -07:00 committed by GitHub
parent fa9d703aa0
commit a2ea1cacc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/components/app/cancel-speedup-popover/cancel-speedup-popover.js
View File

@ -119,7 +119,9 @@ const CancelSpeedupPopover = () => {
contentText={ contentText={
<Box> <Box>
{t('cancelSpeedUpTransactionTooltip', [ {t('cancelSpeedUpTransactionTooltip', [
EDIT_GAS_MODES.CANCEL ? t('cancel') : t('speedUp'), editGasMode === EDIT_GAS_MODES.CANCEL
? t('cancel')
: t('speedUp'),
])} ])}
<div> <div>
<a <a

25
ui/components/app/cancel-speedup-popover/cancel-speedup-popover.test.js
View File

@ -15,6 +15,7 @@ import {
hexWEIToDecETH, hexWEIToDecETH,
decGWEIToHexWEI, decGWEIToHexWEI,
} from '../../../helpers/utils/conversions.util'; } from '../../../helpers/utils/conversions.util';
import InfoTooltip from '../../ui/info-tooltip';
import CancelSpeedupPopover from './cancel-speedup-popover'; import CancelSpeedupPopover from './cancel-speedup-popover';
@ -72,6 +73,8 @@ jest.mock('../../../contexts/transaction-modal', () => ({
}), }),
})); }));
jest.mock('../../ui/info-tooltip', () => jest.fn(() => null));
const render = ( const render = (
props, props,
maxFeePerGas = MOCK_SUGGESTED_MEDIUM_MAXFEEPERGAS_HEX_WEI, maxFeePerGas = MOCK_SUGGESTED_MEDIUM_MAXFEEPERGAS_HEX_WEI,
@ -111,6 +114,10 @@ const render = (
}; };
describe('CancelSpeedupPopover', () => { describe('CancelSpeedupPopover', () => {
afterEach(() => {
jest.clearAllMocks();
});
it('should have ❌Cancel in header if editGasMode is cancel', async () => { it('should have ❌Cancel in header if editGasMode is cancel', async () => {
await act(async () => render()); await act(async () => render());
expect(screen.queryByText('❌Cancel')).toBeInTheDocument(); expect(screen.queryByText('❌Cancel')).toBeInTheDocument();
@ -121,6 +128,24 @@ describe('CancelSpeedupPopover', () => {
expect(screen.queryByText('🚀Speed Up')).toBeInTheDocument(); expect(screen.queryByText('🚀Speed Up')).toBeInTheDocument();
}); });
it('information tooltip should contain the correct text if editGasMode is cancel', async () => {
await act(async () => render());
expect(
InfoTooltip.mock.calls[0][0].contentText.props.children[0],
).toStrictEqual(
'To Cancel a transaction the gas fee must be increased by at least 10% for it to be recognized by the network.',
);
});
it('information tooltip should contain the correct text if editGasMode is speedup', async () => {
await act(async () => render({ editGasMode: EDIT_GAS_MODES.SPEED_UP }));
expect(
InfoTooltip.mock.calls[0][0].contentText.props.children[0],
).toStrictEqual(
'To Speed Up a transaction the gas fee must be increased by at least 10% for it to be recognized by the network.',
);
});
it('should show correct gas values, increased by 10%, when initial initial gas value is above estimated medium', async () => { it('should show correct gas values, increased by 10%, when initial initial gas value is above estimated medium', async () => {
await act(async () => await act(async () =>
render( render(