1
0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-26 12:29:06 +01:00

Move Browserify transforms to gulpfile (#6768)

The flat tests also rely upon these transformations, yet invoke
browserify from the command line rather than using the gulpfile. The
transformations have been specified on the command line for those
instead.

Of course it's not ideal to have the same transformations listed in two
different places, but the plan is to delete the flat tests soon anyway,
so this should suffice until then.

Closes #4538
This commit is contained in:
Mark Stacey 2019-07-01 21:26:24 -03:00 committed by GitHub
parent 448720327b
commit 9fd8a3d46e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions

View File

@ -501,6 +501,8 @@ function generateBundler (opts, performBundle) {
} }
let bundler = browserify(browserifyOpts) let bundler = browserify(browserifyOpts)
.transform('babelify')
.transform('brfs')
if (opts.buildLib) { if (opts.buildLib) {
bundler = bundler.require(opts.dependenciesToBundle) bundler = bundler.require(opts.dependenciesToBundle)

View File

@ -31,7 +31,7 @@
"test:flat:build:tests": "node test/integration/index.js", "test:flat:build:tests": "node test/integration/index.js",
"test:flat:build:states": "node development/genStates.js", "test:flat:build:states": "node development/genStates.js",
"test:flat:build:locales": "mkdirp dist/chrome && cp -R app/_locales dist/chrome/_locales", "test:flat:build:locales": "mkdirp dist/chrome && cp -R app/_locales dist/chrome/_locales",
"test:flat:build:ui": "npm run test:flat:build:states && browserify ./development/mock-dev.js -o ./development/bundle.js", "test:flat:build:ui": "npm run test:flat:build:states && browserify --transform babelify --transform brfs ./development/mock-dev.js -o ./development/bundle.js",
"ganache:start": "ganache-cli --noVMErrorsOnRPCResponse -i 5777 -m 'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent'", "ganache:start": "ganache-cli --noVMErrorsOnRPCResponse -i 5777 -m 'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent'",
"sentry:publish": "node ./development/sentry-publish.js", "sentry:publish": "node ./development/sentry-publish.js",
"lint": "eslint .", "lint": "eslint .",
@ -45,12 +45,6 @@
"update-changelog": "./development/auto-changelog.sh", "update-changelog": "./development/auto-changelog.sh",
"rollback": "./development/rollback.sh" "rollback": "./development/rollback.sh"
}, },
"browserify": {
"transform": [
"babelify",
"brfs"
]
},
"dependencies": { "dependencies": {
"@material-ui/core": "1.0.0", "@material-ui/core": "1.0.0",
"@sentry/browser": "^4.1.1", "@sentry/browser": "^4.1.1",