From 02fa5c9c32bc1aac8b6d6b1e8f5945a9b3be144a Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Wed, 4 Apr 2018 00:09:11 -0700 Subject: [PATCH 1/6] Make token helpscout link open in new tab. --- ui/app/add-token.js | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/app/add-token.js b/ui/app/add-token.js index a73874320..46564a5e5 100644 --- a/ui/app/add-token.js +++ b/ui/app/add-token.js @@ -360,6 +360,7 @@ AddTokenScreen.prototype.renderTabs = function () { h('div.add-token__info-box__copy', this.context.t('keepTrackTokens')), h('a.add-token__info-box__copy--blue', { href: 'http://metamask.helpscoutdocs.com/article/16-managing-erc20-tokens', + target: '_blank', }, this.context.t('learnMore')), ]), h('div.add-token__input-container', [ From 18e0a7e4f98fcad3c49fecf94bcfdc9bb1b50e0f Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 4 Apr 2018 16:26:05 -0700 Subject: [PATCH 2/6] Add target=_blank exportAsFile --- old-ui/app/util.js | 1 + ui/app/util.js | 1 + 2 files changed, 2 insertions(+) diff --git a/old-ui/app/util.js b/old-ui/app/util.js index 3f8b4dcc3..30ae308d2 100644 --- a/old-ui/app/util.js +++ b/old-ui/app/util.js @@ -231,6 +231,7 @@ function exportAsFile (filename, data) { window.navigator.msSaveBlob(blob, filename) } else { const elem = window.document.createElement('a') + elem.target = "_blank" elem.href = window.URL.createObjectURL(blob) elem.download = filename document.body.appendChild(elem) diff --git a/ui/app/util.js b/ui/app/util.js index 800ccb218..0888bff0a 100644 --- a/ui/app/util.js +++ b/ui/app/util.js @@ -271,6 +271,7 @@ function exportAsFile (filename, data) { window.navigator.msSaveBlob(blob, filename) } else { const elem = window.document.createElement('a') + elem.target = "_blank" elem.href = window.URL.createObjectURL(blob) elem.download = filename document.body.appendChild(elem) From 467629217f9fd7f84790271066df476aee66be57 Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 4 Apr 2018 16:34:54 -0700 Subject: [PATCH 3/6] Update Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f427d1e1e..546641db9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Current Master +- Fix Download State Logs button [#3791](https://github.com/MetaMask/metamask-extension/issues/3791) + ## 4.5.3 Wed Apr 04 2018 - Fix bug where checksum address are messing with balance issue [#3843](https://github.com/MetaMask/metamask-extension/issues/3843) From 4ffa74cbe6b5415b11ace8c4c2f32bce40a2e247 Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 4 Apr 2018 16:42:54 -0700 Subject: [PATCH 4/6] Change double-quotes to single-quotes --- old-ui/app/util.js | 2 +- ui/app/util.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/old-ui/app/util.js b/old-ui/app/util.js index 30ae308d2..962832ce7 100644 --- a/old-ui/app/util.js +++ b/old-ui/app/util.js @@ -231,7 +231,7 @@ function exportAsFile (filename, data) { window.navigator.msSaveBlob(blob, filename) } else { const elem = window.document.createElement('a') - elem.target = "_blank" + elem.target = '_blank' elem.href = window.URL.createObjectURL(blob) elem.download = filename document.body.appendChild(elem) diff --git a/ui/app/util.js b/ui/app/util.js index 0888bff0a..bbe2bb09e 100644 --- a/ui/app/util.js +++ b/ui/app/util.js @@ -271,7 +271,7 @@ function exportAsFile (filename, data) { window.navigator.msSaveBlob(blob, filename) } else { const elem = window.document.createElement('a') - elem.target = "_blank" + elem.target = '_blank' elem.href = window.URL.createObjectURL(blob) elem.download = filename document.body.appendChild(elem) From 2199b3720c9422af06fe26cf8de19b79be36987a Mon Sep 17 00:00:00 2001 From: Dan Date: Wed, 4 Apr 2018 21:52:12 -0230 Subject: [PATCH 5/6] Allow from and to address to be the same in new-ui. --- ui/app/send-v2.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/app/send-v2.js b/ui/app/send-v2.js index 0f2997fb2..c3b81da5b 100644 --- a/ui/app/send-v2.js +++ b/ui/app/send-v2.js @@ -254,7 +254,6 @@ SendTransactionScreen.prototype.handleToChange = function (to, nickname = '') { const { updateSendTo, updateSendErrors, - from: {address: from}, } = this.props let toError = null @@ -262,8 +261,6 @@ SendTransactionScreen.prototype.handleToChange = function (to, nickname = '') { toError = this.context.t('required') } else if (!isValidAddress(to)) { toError = this.context.t('invalidAddressRecipient') - } else if (to === from) { - toError = this.context.t('fromToSame') } updateSendTo(to, nickname) From 67de7fc0cc05bbfb311fc550c953bbdf6b495ac1 Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Thu, 5 Apr 2018 00:46:55 -0700 Subject: [PATCH 6/6] Bump Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f427d1e1e..d8a265817 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Changelog ## Current Master +- Fix link for 'Learn More' in the Add Token Screen to open to a new tab. ## 4.5.3 Wed Apr 04 2018