From 9b0f8d457b591d73353b970235a4220f382c60f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gabriel=20M=C3=A9ndez?=
 <75638692+gabrielmj23@users.noreply.github.com>
Date: Mon, 24 Jul 2023 13:54:34 -0400
Subject: [PATCH] Migrate Label component to TS (#19146)

* Migrating Label component to TS

* label TS updates

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
Co-authored-by: garrettbear <gwhisten@gmail.com>
---
 ...label.test.js.snap => label.test.tsx.snap} |  0
 .../component-library/label/index.js          |  1 -
 .../component-library/label/index.ts          |  2 +
 .../component-library/label/label.js          | 44 -------------------
 .../{label.stories.js => label.stories.tsx}   | 25 ++++++-----
 .../label/{label.test.js => label.test.tsx}   |  0
 .../component-library/label/label.tsx         | 39 ++++++++++++++++
 .../component-library/label/label.types.ts    | 24 ++++++++++
 8 files changed, 78 insertions(+), 57 deletions(-)
 rename ui/components/component-library/label/__snapshots__/{label.test.js.snap => label.test.tsx.snap} (100%)
 delete mode 100644 ui/components/component-library/label/index.js
 create mode 100644 ui/components/component-library/label/index.ts
 delete mode 100644 ui/components/component-library/label/label.js
 rename ui/components/component-library/label/{label.stories.js => label.stories.tsx} (70%)
 rename ui/components/component-library/label/{label.test.js => label.test.tsx} (100%)
 create mode 100644 ui/components/component-library/label/label.tsx
 create mode 100644 ui/components/component-library/label/label.types.ts

diff --git a/ui/components/component-library/label/__snapshots__/label.test.js.snap b/ui/components/component-library/label/__snapshots__/label.test.tsx.snap
similarity index 100%
rename from ui/components/component-library/label/__snapshots__/label.test.js.snap
rename to ui/components/component-library/label/__snapshots__/label.test.tsx.snap
diff --git a/ui/components/component-library/label/index.js b/ui/components/component-library/label/index.js
deleted file mode 100644
index f28365d90..000000000
--- a/ui/components/component-library/label/index.js
+++ /dev/null
@@ -1 +0,0 @@
-export { Label } from './label';
diff --git a/ui/components/component-library/label/index.ts b/ui/components/component-library/label/index.ts
new file mode 100644
index 000000000..1a984b62c
--- /dev/null
+++ b/ui/components/component-library/label/index.ts
@@ -0,0 +1,2 @@
+export { Label } from './label';
+export type { LabelComponent, LabelProps } from './label.types';
diff --git a/ui/components/component-library/label/label.js b/ui/components/component-library/label/label.js
deleted file mode 100644
index 7eca591b2..000000000
--- a/ui/components/component-library/label/label.js
+++ /dev/null
@@ -1,44 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import classnames from 'classnames';
-import {
-  FontWeight,
-  TextVariant,
-  Display,
-  AlignItems,
-} from '../../../helpers/constants/design-system';
-import { Text } from '..';
-
-export const Label = ({ htmlFor, className, children, ...props }) => (
-  <Text
-    className={classnames(
-      'mm-label',
-      { 'mm-label--html-for': htmlFor },
-      className,
-    )}
-    as="label"
-    htmlFor={htmlFor}
-    variant={TextVariant.bodyMd}
-    fontWeight={FontWeight.Medium}
-    display={Display.InlineFlex}
-    alignItems={AlignItems.center}
-    {...props}
-  >
-    {children}
-  </Text>
-);
-
-Label.propTypes = {
-  /**
-   * The content of the label
-   */
-  children: PropTypes.oneOfType([PropTypes.string, PropTypes.node]),
-  /**
-   * The id of the input associated with the label
-   */
-  htmlFor: PropTypes.string,
-  /**
-   * Additional classNames to be added to the label component
-   */
-  className: PropTypes.string,
-};
diff --git a/ui/components/component-library/label/label.stories.js b/ui/components/component-library/label/label.stories.tsx
similarity index 70%
rename from ui/components/component-library/label/label.stories.js
rename to ui/components/component-library/label/label.stories.tsx
index 9b6554737..d653db4a1 100644
--- a/ui/components/component-library/label/label.stories.js
+++ b/ui/components/component-library/label/label.stories.tsx
@@ -1,7 +1,8 @@
 import React, { useState } from 'react';
+import { ComponentMeta, ComponentStory } from '@storybook/react';
 import {
-  DISPLAY,
-  FLEX_DIRECTION,
+  Display,
+  FlexDirection,
   AlignItems,
   IconColor,
 } from '../../../helpers/constants/design-system';
@@ -37,21 +38,21 @@ export default {
   args: {
     children: 'Label',
   },
-};
+} as ComponentMeta<typeof Label>;
 
-const Template = (args) => <Label {...args} />;
+const Template: ComponentStory<typeof Label> = (args) => <Label {...args} />;
 
 export const DefaultStory = Template.bind({});
 DefaultStory.storyName = 'Default';
 
-export const Children = (args) => (
+export const Children: ComponentStory<typeof Label> = (args) => (
   <Box
-    display={DISPLAY.INLINE_FLEX}
-    flexDirection={FLEX_DIRECTION.COLUMN}
+    display={Display.InlineFlex}
+    flexDirection={FlexDirection.Column}
     gap={2}
   >
     <Label {...args}>Plain text</Label>
-    <Label {...args} display={DISPLAY.FLEX} alignItems={AlignItems.flexStart}>
+    <Label {...args} display={Display.Flex} alignItems={AlignItems.flexStart}>
       Text and icon
       <Icon
         color={IconColor.iconAlternative}
@@ -61,8 +62,8 @@ export const Children = (args) => (
     </Label>
     <Label
       {...args}
-      display={DISPLAY.INLINE_FLEX}
-      flexDirection={FLEX_DIRECTION.COLUMN}
+      display={Display.InlineFlex}
+      flexDirection={FlexDirection.Column}
       alignItems={AlignItems.flexStart}
     >
       Label that wraps an input
@@ -71,13 +72,13 @@ export const Children = (args) => (
   </Box>
 );
 
-export const HtmlFor = (args) => {
+export const HtmlFor: ComponentStory<typeof Label> = (args) => {
   const [value, setValue] = useState('');
   const handleOnChange = (e) => {
     setValue(e.target.value);
   };
   return (
-    <Box display={DISPLAY.INLINE_FLEX} flexDirection={FLEX_DIRECTION.COLUMN}>
+    <Box display={Display.InlineFlex} flexDirection={FlexDirection.Column}>
       <Label {...args} />
       <TextField
         id="add-network"
diff --git a/ui/components/component-library/label/label.test.js b/ui/components/component-library/label/label.test.tsx
similarity index 100%
rename from ui/components/component-library/label/label.test.js
rename to ui/components/component-library/label/label.test.tsx
diff --git a/ui/components/component-library/label/label.tsx b/ui/components/component-library/label/label.tsx
new file mode 100644
index 000000000..4b7cd6e3a
--- /dev/null
+++ b/ui/components/component-library/label/label.tsx
@@ -0,0 +1,39 @@
+import React from 'react';
+import classnames from 'classnames';
+import { Text } from '../text';
+import type { TextProps } from '../text';
+import {
+  FontWeight,
+  TextVariant,
+  Display,
+  AlignItems,
+} from '../../../helpers/constants/design-system';
+import type { PolymorphicRef } from '../box';
+import { LabelProps, LabelComponent } from './label.types';
+
+export const Label: LabelComponent = React.forwardRef(
+  <C extends React.ElementType = 'label'>(
+    { htmlFor, className, children, ...props }: LabelProps<C>,
+    ref?: PolymorphicRef<C>,
+  ) => {
+    return (
+      <Text
+        className={classnames(
+          'mm-label',
+          { 'mm-label--html-for': Boolean(htmlFor) },
+          className ?? '',
+        )}
+        as="label"
+        htmlFor={htmlFor}
+        variant={TextVariant.bodyMd}
+        fontWeight={FontWeight.Medium}
+        display={Display.InlineFlex}
+        alignItems={AlignItems.center}
+        ref={ref}
+        {...(props as TextProps<C>)}
+      >
+        {children}
+      </Text>
+    );
+  },
+);
diff --git a/ui/components/component-library/label/label.types.ts b/ui/components/component-library/label/label.types.ts
new file mode 100644
index 000000000..8f897e445
--- /dev/null
+++ b/ui/components/component-library/label/label.types.ts
@@ -0,0 +1,24 @@
+import type { PolymorphicComponentPropWithRef } from '../box';
+import type { TextStyleUtilityProps } from '../text';
+
+export interface LabelStyleUtilityProps extends TextStyleUtilityProps {
+  /**
+   * The id of the input associated with the label
+   */
+  htmlFor?: string;
+  /**
+   * Additional classNames to assign to the Label component
+   */
+  className?: string;
+  /**
+   * The content of the Label component
+   */
+  children: string | React.ReactNode;
+}
+
+export type LabelProps<C extends React.ElementType> =
+  PolymorphicComponentPropWithRef<C, LabelStyleUtilityProps>;
+
+export type LabelComponent = <C extends React.ElementType = 'label'>(
+  props: LabelProps<C>,
+) => React.ReactElement | null;