m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Use Boolean for filters (#10066)

Browse Source
This commit is contained in:
David Walsh 2020-12-14 11:03:59 -06:00 committed by GitHub
parent 8f40d03299
commit 9a1548368f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/scripts/controllers/incoming-transactions.js
View File

@ -249,9 +249,7 @@ export default class IncomingTransactionsController {
}) })
const incomingTxs = remoteTxs.filter( const incomingTxs = remoteTxs.filter(
(tx) => (tx) => tx.txParams?.to?.toLowerCase() === address.toLowerCase(),
tx.txParams.to &&
tx.txParams.to.toLowerCase() === address.toLowerCase(),
) )
incomingTxs.sort((a, b) => (a.time < b.time ? -1 : 1)) incomingTxs.sort((a, b) => (a.time < b.time ? -1 : 1))

2
ui/app/components/app/gas-customization/gas-modal-page-container/gas-modal-page-container.container.js
View File

@ -321,7 +321,7 @@ function calcCustomGasLimit(customGasLimitInHex) {
} }
function sumHexWEIsToRenderableEth(hexWEIs) { function sumHexWEIsToRenderableEth(hexWEIs) {
const hexWEIsSum = hexWEIs.filter((n) => n).reduce(addHexes) const hexWEIsSum = hexWEIs.filter(Boolean).reduce(addHexes)
return formatETHFee( return formatETHFee(
getValueFromWeiHex({ getValueFromWeiHex({
value: hexWEIsSum, value: hexWEIsSum,

2
ui/app/components/app/multiple-notifications/multiple-notifications.component.js
View File

@ -21,7 +21,7 @@ export default class MultipleNotifications extends PureComponent {
const { showAll } = this.state const { showAll } = this.state
const { children, classNames } = this.props const { children, classNames } = this.props
const childrenToRender = children.filter((child) => child) const childrenToRender = children.filter(Boolean)
if (childrenToRender.length === 0) { if (childrenToRender.length === 0) {
return null return null
} }

2
ui/app/components/ui/page-container/page-container.component.js
View File

@ -67,7 +67,7 @@ export default class PageContainer extends PureComponent {
renderActiveTabContent() { renderActiveTabContent() {
const { tabsComponent } = this.props const { tabsComponent } = this.props
let { children } = tabsComponent.props let { children } = tabsComponent.props
children = children.filter((child) => child) children = children.filter(Boolean)
const { activeTabIndex } = this.state const { activeTabIndex } = this.state
return children[activeTabIndex] return children[activeTabIndex]

2
ui/app/helpers/utils/conversions.util.js
View File

@ -183,7 +183,7 @@ export function addHexes(aHexWEI, bHexWEI) {
} }
export function sumHexWEIs(hexWEIs) { export function sumHexWEIs(hexWEIs) {
return hexWEIs.filter((n) => n).reduce(addHexes) return hexWEIs.filter(Boolean).reduce(addHexes)
} }
export function sumHexWEIsToUnformattedFiat( export function sumHexWEIsToUnformattedFiat(

4
ui/app/hooks/useTokensToSearch.js
View File

@ -145,9 +145,7 @@ export function useTokensToSearch({
return new BigNumber(rawFiat || 0).gt(secondRawFiat || 0) ? -1 : 1 return new BigNumber(rawFiat || 0).gt(secondRawFiat || 0) ? -1 : 1
}, },
) )
tokensToSearchBuckets.top = tokensToSearchBuckets.top.filter( tokensToSearchBuckets.top = tokensToSearchBuckets.top.filter(Boolean)
(token) => token,
)
return [ return [
...tokensToSearchBuckets.owned, ...tokensToSearchBuckets.owned,
...tokensToSearchBuckets.top, ...tokensToSearchBuckets.top,

2
ui/app/pages/swaps/swaps-gas-customization-modal/swaps-gas-customization-modal.container.js
View File

@ -159,7 +159,7 @@ export default connect(
)(SwapsGasCustomizationModalComponent) )(SwapsGasCustomizationModalComponent)
function sumHexWEIsToRenderableEth(hexWEIs) { function sumHexWEIsToRenderableEth(hexWEIs) {
const hexWEIsSum = hexWEIs.filter((n) => n).reduce(addHexes) const hexWEIsSum = hexWEIs.filter(Boolean).reduce(addHexes)
return formatETHFee( return formatETHFee(
getValueFromWeiHex({ getValueFromWeiHex({
value: hexWEIsSum, value: hexWEIsSum,