m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Fix no-useless-catch issues (#9198)

Browse Source 
See [`no-useless-catch`](https://eslint.org/docs/rules/no-useless-catch) for more information.

This change enables `no-useless-catch` and fixes the issues raised by the rule.
This commit is contained in:
Whymarrh Whitby 2020-08-12 16:37:15 -02:30 committed by GitHub
parent a8863a3446
commit 9842b2f1ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -48,6 +48,7 @@ module.exports = {
'global-require': 'error', 'global-require': 'error',
'guard-for-in': 'error', 'guard-for-in': 'error',
'no-case-declarations': 'error', 'no-case-declarations': 'error',
'no-useless-catch': 'error',
/* End v2 rules */ /* End v2 rules */
'arrow-parens': 'error', 'arrow-parens': 'error',
'no-tabs': 'error', 'no-tabs': 'error',

8
app/scripts/metamask-controller.js
View File

@ -601,8 +601,6 @@ export default class MetamaskController extends EventEmitter {
this.selectFirstIdentity() this.selectFirstIdentity()
} }
return vault return vault
} catch (err) {
throw err
} finally { } finally {
releaseLock() releaseLock()
} }
@ -658,8 +656,6 @@ export default class MetamaskController extends EventEmitter {
this.preferencesController.setAddresses(accounts) this.preferencesController.setAddresses(accounts)
this.selectFirstIdentity() this.selectFirstIdentity()
return vault return vault
} catch (err) {
throw err
} finally { } finally {
releaseLock() releaseLock()
} }
@ -1402,13 +1398,9 @@ export default class MetamaskController extends EventEmitter {
* @returns {Object} - MetaMask state * @returns {Object} - MetaMask state
*/ */
async createCancelTransaction (originalTxId, customGasPrice) { async createCancelTransaction (originalTxId, customGasPrice) {
try {
await this.txController.createCancelTransaction(originalTxId, customGasPrice) await this.txController.createCancelTransaction(originalTxId, customGasPrice)
const state = await this.getState() const state = await this.getState()
return state return state
} catch (error) {
throw error
}
} }
async createSpeedUpTransaction (originalTxId, customGasPrice, customGasLimit) { async createSpeedUpTransaction (originalTxId, customGasPrice, customGasLimit) {