m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-10-22 11:22:43 +02:00
Code

Reduce e2e test flakiness (#19507)

Browse Source 
Three e2e tests have been updated to fix a possible race condition
causing intermittent e2e test failures.

In each of the updated tests, the test checks the current network.
The check is performed as a two-step process: locate the current
network element, then check the text to ensure it's correct.

This fails when the test driver finds the element before it re-renders.
If the test runs too quickly, it compares the text before the switch
is shown on screen, and the test fails.

Instead the tests use the element locator to describe what they want.
This tells the test driver to keep looking until the conditions are
met, ensuring the test doesn't fail unless the network switch takes
longer than the default timeout (which should not happen).

This is a good example of why we should avoid using assertions on
elements in e2e tests. Express your assertions as locators instead to
make the test more resilient in the case where the test runs before the
next render.
This commit is contained in:
Mark Stacey 2023-06-08 14:34:48 -02:30 committed by GitHub
parent f5b158dda6
commit 96c00df6f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/e2e/tests/chain-interactions.spec.js
View File

@ -55,10 +55,10 @@ describe('Chain Interactions', function () {
await driver.switchToWindow(extension); await driver.switchToWindow(extension);
// verify networks // verify networks
const networkDisplay = await driver.findElement( await driver.findElement({
'[data-testid="network-display"] p', css: '[data-testid="network-display"]',
); text: 'Localhost 8545',
assert.equal(await networkDisplay.getText(), 'Localhost 8545'); });
await driver.clickElement('[data-testid="network-display"]'); await driver.clickElement('[data-testid="network-display"]');
const ganacheChain = await driver.findElements({ const ganacheChain = await driver.findElements({
@ -103,10 +103,10 @@ describe('Chain Interactions', function () {
await driver.switchToWindow(extension); await driver.switchToWindow(extension);
// verify current network // verify current network
const networkDisplay = await driver.findElement( await driver.findElement({
'[data-testid="network-display"] p', css: '[data-testid="network-display"]',
); text: `Localhost ${port}`,
assert.equal(await networkDisplay.getText(), `Localhost ${port}`); });
}, },
); );
}); });

8
test/e2e/tests/onboarding.spec.js
View File

@ -301,10 +301,10 @@ describe('MetaMask onboarding', function () {
assert.equal(networkNotification, true); assert.equal(networkNotification, true);
// Check localhost 8546 is selected and its balance value is correct // Check localhost 8546 is selected and its balance value is correct
const networkDisplay = await driver.findElement( await driver.findElement({
'[data-testid="network-display"] p', css: '[data-testid="network-display"]',
); text: networkName,
assert.equal(await networkDisplay.getText(), networkName); });
await assertAccountBalanceForDOM(driver, secondaryGanacheServer); await assertAccountBalanceForDOM(driver, secondaryGanacheServer);
}, },