From 95acee95b542274095035e04cd1efef166289476 Mon Sep 17 00:00:00 2001 From: Kevin Holder Date: Fri, 11 Sep 2020 08:28:51 -0400 Subject: [PATCH] nodeify removeFromAddressBook (#9395) Right now when editing an address in "Settings > Contact", the contact is lost after saving. This is because the code awaits `removeFromAddressBook()` before creating the new contact but `removeFromAddressBook()` never resolves. This change fixes this bug. --- app/scripts/metamask-controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 8d1c462a5..46b8f0383 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -484,7 +484,7 @@ export default class MetamaskController extends EventEmitter { // AddressController setAddressBook: nodeify(this.addressBookController.set, this.addressBookController), - removeFromAddressBook: this.addressBookController.delete.bind(this.addressBookController), + removeFromAddressBook: nodeify(this.addressBookController.delete, this.addressBookController), // AppStateController setLastActiveTime: nodeify(this.appStateController.setLastActiveTime, this.appStateController),