m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

fix(878): fix toggle align styles for eth-sign in settings (#20587)

Browse Source
This commit is contained in:
Danica Shen 2023-08-24 14:11:38 +01:00 committed by GitHub
parent 00d155ce2f
commit 9514b47a7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/pages/settings/advanced-tab/__snapshots__/advanced-tab.component.test.js.snap
View File

@ -586,7 +586,7 @@ exports[`AdvancedTab Component should match snapshot 1`] = `
</div> </div>
</div> </div>
<div <div
class="mm-box settings-page__content-row mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-space-between" class="mm-box settings-page__content-row mm-box--display-flex mm-box--flex-direction-column"
data-testid="advanced-setting-toggle-ethsign" data-testid="advanced-setting-toggle-ethsign"
> >
<div <div

11
ui/pages/settings/advanced-tab/advanced-tab.component.js
View File

@ -10,7 +10,7 @@ import {
Display, Display,
FlexDirection, FlexDirection,
JustifyContent, JustifyContent,
SEVERITIES, Severity,
TextVariant, TextVariant,
} from '../../../helpers/constants/design-system'; } from '../../../helpers/constants/design-system';
import { getPlatform } from '../../../../app/scripts/lib/util'; import { getPlatform } from '../../../../app/scripts/lib/util';
@ -600,8 +600,7 @@ export default class AdvancedTab extends PureComponent {
className="settings-page__content-row" className="settings-page__content-row"
data-testid="advanced-setting-toggle-ethsign" data-testid="advanced-setting-toggle-ethsign"
display={Display.Flex} display={Display.Flex}
flexDirection={FlexDirection.Row} flexDirection={FlexDirection.Column}
justifyContent={JustifyContent.spaceBetween}
> >
<div className="settings-page__content-item"> <div className="settings-page__content-item">
<span>{t('toggleEthSignField')}</span> <span>{t('toggleEthSignField')}</span>
@ -609,11 +608,11 @@ export default class AdvancedTab extends PureComponent {
{t('toggleEthSignDescriptionField')} {t('toggleEthSignDescriptionField')}
</div> </div>
</div> </div>
{disabledRpcMethodPreferences?.eth_sign ? ( {disabledRpcMethodPreferences?.eth_sign ? (
<BannerAlert <BannerAlert
severity={SEVERITIES.DANGER} severity={Severity.Danger}
marginBottom={5} marginTop={3}
marginBottom={4}
descriptionProps={{ variant: TextVariant.bodyMd }} descriptionProps={{ variant: TextVariant.bodyMd }}
> >
{t('toggleEthSignBannerDescription')} {t('toggleEthSignBannerDescription')}