From 5026c1e6d0f5b388c61693dbc1ab85245c8bb12d Mon Sep 17 00:00:00 2001 From: MetaMask Bot Date: Wed, 24 Feb 2021 16:37:34 +0000 Subject: [PATCH 1/6] Version v9.1.0 --- CHANGELOG.md | 2 ++ app/manifest/_base.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8c9577b8..d17746e88 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Current Develop Branch +## 9.1.0 Wed Feb 24 2021 + ## 9.0.5 Mon Feb 08 2021 - [#10278](https://github.com/MetaMask/metamask-extension/pull/10278): Allow editing transaction amount after clicking max - [#10214](https://github.com/MetaMask/metamask-extension/pull/10214): Standardize size, shape and color of network color indicators diff --git a/app/manifest/_base.json b/app/manifest/_base.json index 3d2edff7f..2e0a5d625 100644 --- a/app/manifest/_base.json +++ b/app/manifest/_base.json @@ -78,6 +78,6 @@ "notifications" ], "short_name": "__MSG_appName__", - "version": "9.0.5", + "version": "9.1.0", "web_accessible_resources": ["inpage.js", "phishing.html"] } From 1884ea20737abef95341ef438be1a2f9230bd169 Mon Sep 17 00:00:00 2001 From: Thomas Huang Date: Mon, 1 Mar 2021 10:34:16 -0800 Subject: [PATCH 2/6] Update changelog for v9.1.0 (#10526) --- CHANGELOG.md | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d17746e88..088caecb7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,40 @@ ## Current Develop Branch -## 9.1.0 Wed Feb 24 2021 +## 9.1.0 Mon Mar 01 2021 +- [#10265](https://github.com/MetaMask/metamask-extension/pull/10265): Update Japanese translations. +- [#9388](https://github.com/MetaMask/metamask-extension/pull/9388): Update Chinese(Simplified) translations. +- [#10270](https://github.com/MetaMask/metamask-extension/pull/10270): Update Vietnamese translations. +- [#10258](https://github.com/MetaMask/metamask-extension/pull/10258): Update Spanish and Spanish(Latin American and Carribean) translations. +- [#10268](https://github.com/MetaMask/metamask-extension/pull/10268): Update Russian translations. +- [#10269](https://github.com/MetaMask/metamask-extension/pull/10269): Update Tagalog localized messages. +- [#10448](https://github.com/MetaMask/metamask-extension/pull/10448): Fix 'imported' translation use case for Dutch. +- [#10391](https://github.com/MetaMask/metamask-extension/pull/10391): Use translated transaction category for confirmations. +- [#10357](https://github.com/MetaMask/metamask-extension/pull/10357): Cancel unapproved confirmations on network change +- [#10413](https://github.com/MetaMask/metamask-extension/pull/10413): Use native currency in asset row. +- [#10421](https://github.com/MetaMask/metamask-extension/pull/10421): Fix color indicator size on connected site indicator. +- [#10423](https://github.com/MetaMask/metamask-extension/pull/10423): Fix multiple notification window prompts. +- [#10424](https://github.com/MetaMask/metamask-extension/pull/10424): Fix icons on token options menu. +- [#10414](https://github.com/MetaMask/metamask-extension/pull/10414): Fix token fiat conversion rates when switching from certain custom networks. +- [#10453](https://github.com/MetaMask/metamask-extension/pull/10453): Disable BUY button from home screen when not on Ethereum Mainnet. +- [#10465](https://github.com/MetaMask/metamask-extension/pull/10465): Fixes gas selection check mark on the notification view. +- [#10467](https://github.com/MetaMask/metamask-extension/pull/10467): Fix confirm page header with from/to addresses in fullscreen for tx confirmations. +- [#10455](https://github.com/MetaMask/metamask-extension/pull/10455): Hide links to etherscan when no block explorer is specified for a custom network for notifications. +- [#10456](https://github.com/MetaMask/metamask-extension/pull/10456): Fix swap insufficient balance error message. +- [#10350](https://github.com/MetaMask/metamask-extension/pull/10350): Fix encypt/decrypt tx queueing. +- [#10473](https://github.com/MetaMask/metamask-extension/pull/10473): Improve autofocus in the add network form. +- [#10444](https://github.com/MetaMask/metamask-extension/pull/10444): Use eth_gasprice for tx gas price estimation on non-Mainnet networks. +- [#10477](https://github.com/MetaMask/metamask-extension/pull/10477): Fix accountsChanged event not triggering when manually connecting. +- [#10471](https://github.com/MetaMask/metamask-extension/pull/10471): Fix navigation from jumping vertically when clicking into token. +- [#9724](https://github.com/MetaMask/metamask-extension/pull/9724): Add custom network RPC method. +- [#10496](https://github.com/MetaMask/metamask-extension/pull/10496): Eliminate artificial delay in swaps loading screen after request loading is complete. +- [#10501](https://github.com/MetaMask/metamask-extension/pull/10501): Ensure that swap approve tx and swap tx always have the same gas price. +- [#10485](https://github.com/MetaMask/metamask-extension/pull/10485): Fixes signTypedData message overflow. +- [#10525](https://github.com/MetaMask/metamask-extension/pull/10525): Update swaps failure message to include a support link. +- [#10521](https://github.com/MetaMask/metamask-extension/pull/10521): Accommodate for 0 sources verifying swap token +- [#10530](https://github.com/MetaMask/metamask-extension/pull/10530): Show warnings on Add Recipient page of Send flow +- [#9187](https://github.com/MetaMask/metamask-extension/pull/9187): Warn users when an ENS name contains 'confusable' characters +- [#10507](https://github.com/MetaMask/metamask-extension/pull/10507): Fixes ENS IPFS resolution on custom networks with the chainID of 1. ## 9.0.5 Mon Feb 08 2021 - [#10278](https://github.com/MetaMask/metamask-extension/pull/10278): Allow editing transaction amount after clicking max From 9d97dcb22e6f34a451845fd55fbde951b2dfb34b Mon Sep 17 00:00:00 2001 From: MetaMask Bot Date: Wed, 3 Mar 2021 19:07:29 +0000 Subject: [PATCH 3/6] Version v9.1.1 --- CHANGELOG.md | 2 ++ app/manifest/_base.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 088caecb7..093b0fd53 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Current Develop Branch +## 9.1.1 Wed Mar 03 2021 + ## 9.1.0 Mon Mar 01 2021 - [#10265](https://github.com/MetaMask/metamask-extension/pull/10265): Update Japanese translations. - [#9388](https://github.com/MetaMask/metamask-extension/pull/9388): Update Chinese(Simplified) translations. diff --git a/app/manifest/_base.json b/app/manifest/_base.json index 2e0a5d625..8c04191bb 100644 --- a/app/manifest/_base.json +++ b/app/manifest/_base.json @@ -78,6 +78,6 @@ "notifications" ], "short_name": "__MSG_appName__", - "version": "9.1.0", + "version": "9.1.1", "web_accessible_resources": ["inpage.js", "phishing.html"] } From 615f87e12ee2ee0e0621b850dfa30a5a708bc18d Mon Sep 17 00:00:00 2001 From: Brad Decker Date: Tue, 2 Mar 2021 18:20:37 -0600 Subject: [PATCH 4/6] handle undefined network (#10560) --- .../add-recipient/ens-input.component.js | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js index a0977406e..f984f13d8 100644 --- a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js +++ b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js @@ -72,10 +72,19 @@ export default class EnsInput extends Component { } if (prevProps.network !== network) { - const provider = global.ethereumProvider; - this.ens = new ENS({ provider, network }); - if (!newProvidedValue) { - newValue = input; + if (getNetworkEnsSupport(network)) { + const provider = global.ethereumProvider; + this.ens = new ENS({ provider, network }); + this.checkName = debounce(this.lookupEnsName, 200); + if (!newProvidedValue) { + newValue = input; + } + } else { + // ens is null on mount on a network that does not have ens support + // this is intended to prevent accidental lookup of domains across + // networks + this.ens = null; + this.checkName = null; } } From d034adfb2446686e23a4ccf86b7b0c61d319689e Mon Sep 17 00:00:00 2001 From: Shane Date: Tue, 2 Mar 2021 14:19:56 -0800 Subject: [PATCH 5/6] Fix/handle safe low undefined (#10561) * fix: handle safeLow undefined fixes #10558 * fix: add tests for isCustomGasPriceSafe selector --- ui/app/selectors/custom-gas.js | 2 +- ui/app/selectors/tests/custom-gas.test.js | 39 +++++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/ui/app/selectors/custom-gas.js b/ui/app/selectors/custom-gas.js index b6662c03b..2cb40f5a6 100644 --- a/ui/app/selectors/custom-gas.js +++ b/ui/app/selectors/custom-gas.js @@ -64,7 +64,7 @@ export function isCustomPriceSafe(state) { return true; } - if (safeLow === null) { + if (!safeLow) { return false; } diff --git a/ui/app/selectors/tests/custom-gas.test.js b/ui/app/selectors/tests/custom-gas.test.js index 020648fbd..3afb1afdd 100644 --- a/ui/app/selectors/tests/custom-gas.test.js +++ b/ui/app/selectors/tests/custom-gas.test.js @@ -6,6 +6,7 @@ const { getCustomGasPrice, getRenderableBasicEstimateData, getRenderableEstimateDataForSmallButtonsFromGWEI, + isCustomPriceSafe, } = proxyquire('../custom-gas', {}); describe('custom-gas selectors', function () { @@ -15,6 +16,44 @@ describe('custom-gas selectors', function () { assert.strictEqual(getCustomGasPrice(mockState), 'mockPrice'); }); }); + describe('isCustomGasPriceSafe()', function () { + it('should return true for gas.customData.price 0x77359400', function () { + const mockState = { + gas: { + customData: { price: '0x77359400' }, + basicEstimates: { safeLow: 1 }, + }, + }; + assert.strictEqual(isCustomPriceSafe(mockState), true); + }); + it('should return true for gas.customData.price null', function () { + const mockState = { + gas: { + customData: { price: null }, + basicEstimates: { safeLow: 1 }, + }, + }; + assert.strictEqual(isCustomPriceSafe(mockState), true); + }); + it('should return true gas.customData.price undefined', function () { + const mockState = { + gas: { + customData: { price: undefined }, + basicEstimates: { safeLow: 1 }, + }, + }; + assert.strictEqual(isCustomPriceSafe(mockState), true); + }); + it('should return false gas.basicEstimates.safeLow undefined', function () { + const mockState = { + gas: { + customData: { price: '0x77359400' }, + basicEstimates: { safeLow: undefined }, + }, + }; + assert.strictEqual(isCustomPriceSafe(mockState), false); + }); + }); describe('getCustomGasLimit()', function () { it('should return gas.customData.limit', function () { From 996e8e75e15ab95a1e2c481a9b285c57bf46ebf6 Mon Sep 17 00:00:00 2001 From: Brad Decker Date: Wed, 3 Mar 2021 13:40:51 -0600 Subject: [PATCH 6/6] [skip e2e] Update changelog for v9.1.1 (#10575) --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 093b0fd53..fc20d601f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ ## Current Develop Branch ## 9.1.1 Wed Mar 03 2021 +- [#10560](https://github.com/MetaMask/metamask-extension/pull/10560): Fix ENS resolution related crashes when switching networks on send screen +- [#10561](https://github.com/MetaMask/metamask-extension/pull/10561): Fix crash when speeding up an attempt to cancel a transaction on custom networks ## 9.1.0 Mon Mar 01 2021 - [#10265](https://github.com/MetaMask/metamask-extension/pull/10265): Update Japanese translations.