From 91f6545c095d9a00bd39fce052a2a7b5a117d605 Mon Sep 17 00:00:00 2001 From: David Walsh Date: Fri, 4 Aug 2023 13:28:34 -0500 Subject: [PATCH] UX: Remove the 'Source' and 'Link' URLs from NFT detail (#20248) --- app/_locales/de/messages.json | 3 - app/_locales/el/messages.json | 3 - app/_locales/en/messages.json | 3 - app/_locales/es/messages.json | 3 - app/_locales/es_419/messages.json | 3 - app/_locales/fr/messages.json | 3 - app/_locales/hi/messages.json | 3 - app/_locales/id/messages.json | 3 - app/_locales/ja/messages.json | 3 - app/_locales/ko/messages.json | 3 - app/_locales/pt/messages.json | 3 - app/_locales/pt_BR/messages.json | 3 - app/_locales/ru/messages.json | 3 - app/_locales/tl/messages.json | 3 - app/_locales/tr/messages.json | 3 - app/_locales/vi/messages.json | 3 - app/_locales/zh_CN/messages.json | 3 - test/e2e/nft/view-erc1155-details.spec.js | 7 -- test/e2e/nft/view-nft-details.spec.js | 7 -- .../__snapshots__/nft-details.test.js.snap | 21 ------ ui/components/app/nft-details/nft-details.js | 68 ------------------- 21 files changed, 154 deletions(-) diff --git a/app/_locales/de/messages.json b/app/_locales/de/messages.json index 0b04f0b38..9379779b6 100644 --- a/app/_locales/de/messages.json +++ b/app/_locales/de/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Hoppla! Da hat etwas nicht geklappt." }, - "source": { - "message": "Quelle" - }, "speedUp": { "message": "Beschleunigen" }, diff --git a/app/_locales/el/messages.json b/app/_locales/el/messages.json index 08c2c18a1..5875c30e2 100644 --- a/app/_locales/el/messages.json +++ b/app/_locales/el/messages.json @@ -3243,9 +3243,6 @@ "somethingWentWrong": { "message": "Ουπς! Κάτι πήγε στραβά." }, - "source": { - "message": "Πηγή" - }, "speedUp": { "message": "Επιτάχυνση" }, diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index a8f43027c..18e28b7d9 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -4107,9 +4107,6 @@ "somethingWentWrong": { "message": "Oops! Something went wrong." }, - "source": { - "message": "Source" - }, "speedUp": { "message": "Speed up" }, diff --git a/app/_locales/es/messages.json b/app/_locales/es/messages.json index 1b5cc399b..be5afad23 100644 --- a/app/_locales/es/messages.json +++ b/app/_locales/es/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Lo lamentamos, se produjo un error." }, - "source": { - "message": "Fuente" - }, "speedUp": { "message": "Acelerar" }, diff --git a/app/_locales/es_419/messages.json b/app/_locales/es_419/messages.json index 39bf031c3..6e209ec6b 100644 --- a/app/_locales/es_419/messages.json +++ b/app/_locales/es_419/messages.json @@ -2062,9 +2062,6 @@ "somethingWentWrong": { "message": "Lo lamentamos, se produjo un error." }, - "source": { - "message": "Fuente" - }, "speedUp": { "message": "Acelerar" }, diff --git a/app/_locales/fr/messages.json b/app/_locales/fr/messages.json index 4d3f53a91..340f707c6 100644 --- a/app/_locales/fr/messages.json +++ b/app/_locales/fr/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Oups ! Quelque chose a mal tourné. " }, - "source": { - "message": "Source" - }, "speedUp": { "message": "Accélérer" }, diff --git a/app/_locales/hi/messages.json b/app/_locales/hi/messages.json index 346c660cf..1a69af91b 100644 --- a/app/_locales/hi/messages.json +++ b/app/_locales/hi/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "ओह! कुछ गलत हो गया।" }, - "source": { - "message": "स्रोत" - }, "speedUp": { "message": "जल्दी करें" }, diff --git a/app/_locales/id/messages.json b/app/_locales/id/messages.json index 02a837c40..7a7fc5eb2 100644 --- a/app/_locales/id/messages.json +++ b/app/_locales/id/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Ups! Ada yang salah." }, - "source": { - "message": "Sumber" - }, "speedUp": { "message": "Percepat" }, diff --git a/app/_locales/ja/messages.json b/app/_locales/ja/messages.json index 990ea54d1..58225cb1e 100644 --- a/app/_locales/ja/messages.json +++ b/app/_locales/ja/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "申し訳ありません。問題が発生しました。" }, - "source": { - "message": "ソース" - }, "speedUp": { "message": "スピードアップ" }, diff --git a/app/_locales/ko/messages.json b/app/_locales/ko/messages.json index 8cc518f6d..fccf6041d 100644 --- a/app/_locales/ko/messages.json +++ b/app/_locales/ko/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "죄송합니다! 문제가 생겼습니다." }, - "source": { - "message": "소스" - }, "speedUp": { "message": "가속화" }, diff --git a/app/_locales/pt/messages.json b/app/_locales/pt/messages.json index 59352f0f3..c3d06b188 100644 --- a/app/_locales/pt/messages.json +++ b/app/_locales/pt/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Ops! Algo deu errado." }, - "source": { - "message": "Origem" - }, "speedUp": { "message": "Acelerar" }, diff --git a/app/_locales/pt_BR/messages.json b/app/_locales/pt_BR/messages.json index 20e8daa1e..b023dbb67 100644 --- a/app/_locales/pt_BR/messages.json +++ b/app/_locales/pt_BR/messages.json @@ -2062,9 +2062,6 @@ "somethingWentWrong": { "message": "Opa! Ocorreu algum erro." }, - "source": { - "message": "Fonte" - }, "speedUp": { "message": "Acelerar" }, diff --git a/app/_locales/ru/messages.json b/app/_locales/ru/messages.json index 4e36e6b1a..2e0f11573 100644 --- a/app/_locales/ru/messages.json +++ b/app/_locales/ru/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Ой! Что-то пошло не так." }, - "source": { - "message": "Источник" - }, "speedUp": { "message": "Ускорить" }, diff --git a/app/_locales/tl/messages.json b/app/_locales/tl/messages.json index 335150f97..cff8ca4b2 100644 --- a/app/_locales/tl/messages.json +++ b/app/_locales/tl/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Oops! Nagkaproblema." }, - "source": { - "message": "Pinagmulan" - }, "speedUp": { "message": "Pabilisin" }, diff --git a/app/_locales/tr/messages.json b/app/_locales/tr/messages.json index adad63696..b181d5d95 100644 --- a/app/_locales/tr/messages.json +++ b/app/_locales/tr/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Eyvah! Bir şeyler ters gitti." }, - "source": { - "message": "Kaynak" - }, "speedUp": { "message": "Hızlandır" }, diff --git a/app/_locales/vi/messages.json b/app/_locales/vi/messages.json index f76a0beb4..982edf876 100644 --- a/app/_locales/vi/messages.json +++ b/app/_locales/vi/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "Rất tiếc! Đã xảy ra sự cố." }, - "source": { - "message": "Nguồn" - }, "speedUp": { "message": "Tăng tốc" }, diff --git a/app/_locales/zh_CN/messages.json b/app/_locales/zh_CN/messages.json index e65b42b81..303e62866 100644 --- a/app/_locales/zh_CN/messages.json +++ b/app/_locales/zh_CN/messages.json @@ -3246,9 +3246,6 @@ "somethingWentWrong": { "message": "哎呀！出了点问题。" }, - "source": { - "message": "来源" - }, "speedUp": { "message": "加速" }, diff --git a/test/e2e/nft/view-erc1155-details.spec.js b/test/e2e/nft/view-erc1155-details.spec.js index 3d811b8bb..99133de7f 100644 --- a/test/e2e/nft/view-erc1155-details.spec.js +++ b/test/e2e/nft/view-erc1155-details.spec.js @@ -16,8 +16,6 @@ describe('View ERC1155 NFT details', function () { }; it('user should be able to view ERC1155 NFT details', async function () { - const expectedImageSource = - 'https://bafkreifvhjdf6ve4jfv6qytqtux5nd4nwnelioeiqx5x2ez5yrgrzk7ypi.ipfs.dweb.link'; await withFixtures( { dapp: true, @@ -57,11 +55,6 @@ describe('View ERC1155 NFT details', function () { const nftImage = await driver.findElement('.nft-item__container'); assert.equal(await nftImage.isDisplayed(), true); - const nftImageSource = await driver.findElement( - '.nft-details__image-source', - ); - assert.equal(await nftImageSource.getText(), expectedImageSource); - const nftContract = await driver.findElement( '.nft-details__contract-wrapper', ); diff --git a/test/e2e/nft/view-nft-details.spec.js b/test/e2e/nft/view-nft-details.spec.js index 07251050a..2648085dd 100644 --- a/test/e2e/nft/view-nft-details.spec.js +++ b/test/e2e/nft/view-nft-details.spec.js @@ -16,8 +16,6 @@ describe('View NFT details', function () { }; it('user should be able to view ERC721 NFT details', async function () { - const expectedImageSource = - 'data:image/svg+xml;base64,PHN2ZyBoZWlnaHQ9IjM1MCIgd2lkdGg9IjM1MCIgdmlld0JveD0iMCAwIDEwMCAxMDAiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+PGRlZnM+PHBhdGggaWQ9Ik15UGF0aCIgZmlsbD0ibm9uZSIgc3Ryb2tlPSJyZWQiIGQ9Ik0xMCw5MCBROTAsOTAgOTAsNDUgUTkwLDEwIDUwLDEwIFExMCwxMCAxMCw0MCBRMTAsNzAgNDUsNzAgUTcwLDcwIDc1LDUwIiAvPjwvZGVmcz48dGV4dD48dGV4dFBhdGggaHJlZj0iI015UGF0aCI+UXVpY2sgYnJvd24gZm94IGp1bXBzIG92ZXIgdGhlIGxhenkgZG9nLjwvdGV4dFBhdGg+PC90ZXh0Pjwvc3ZnPg=='; await withFixtures( { dapp: true, @@ -56,11 +54,6 @@ describe('View NFT details', function () { const nftImage = await driver.findElement('.nft-item__container'); assert.equal(await nftImage.isDisplayed(), true); - const nftImageSource = await driver.findElement( - '.nft-details__image-source', - ); - assert.equal(await nftImageSource.getText(), expectedImageSource); - const nftContract = await driver.findElement( '.nft-details__contract-wrapper', ); diff --git a/ui/components/app/nft-details/__snapshots__/nft-details.test.js.snap b/ui/components/app/nft-details/__snapshots__/nft-details.test.js.snap index 9d3a04c70..947973a70 100644 --- a/ui/components/app/nft-details/__snapshots__/nft-details.test.js.snap +++ b/ui/components/app/nft-details/__snapshots__/nft-details.test.js.snap @@ -141,27 +141,6 @@ exports[`NFT Details should match minimal props and state snapshot 1`] = ` -
-
- Source -
-
- - https://bafybeiclzx7zfjvuiuwobn5ip3ogc236bjqfjzoblumf4pau4ep6dqramu.ipfs.dweb.link - -
-
diff --git a/ui/components/app/nft-details/nft-details.js b/ui/components/app/nft-details/nft-details.js index e6f8f9db2..62d050310 100644 --- a/ui/components/app/nft-details/nft-details.js +++ b/ui/components/app/nft-details/nft-details.js @@ -67,7 +67,6 @@ export default function NftDetails({ nft }) { standard, isCurrentlyOwned, lastSale, - imageThumbnail, } = nft; const t = useI18nContext(); const history = useHistory(); @@ -87,7 +86,6 @@ export default function NftDetails({ nft }) { ); const nftImageAlt = getNftImageAlt(nft); const nftImageURL = getAssetImageURL(imageOriginal ?? image, ipfsGateway); - const isDataURI = nftImageURL.startsWith('data:'); const formattedTimestamp = formatDate( new Date(lastSale?.event_timestamp).getTime(), @@ -309,72 +307,6 @@ export default function NftDetails({ nft }) { ) : null} - - - {t('source')} - - - {isDataURI ? ( - <>{nftImageURL} - ) : ( - - {nftImageURL} - - )} - - - {imageThumbnail ? ( - - - {t('link')} - - - - {imageThumbnail} - - - - ) : null}