m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

Don't call "toPrecisionWithoutTrailingZeros" if a destination value is not a number (#20525)

Browse Source
This commit is contained in:
Daniel 2023-08-21 18:06:12 +02:00 committed by GitHub
parent 702ee233e7
commit 8ca0b762ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/pages/swaps/swaps.util.test.js
View File

@ -401,6 +401,12 @@ describe('Swaps Util', () => {
'39.6493201125', '39.6493201125',
); );
}); });
it('gets swaps value for display when the value contains three dots', () => {
expect(formatSwapsValueForDisplay('33680099000000000000...')).toBe(
'33680099000000000000...',
);
});
}); });
describe('getSwapsTokensReceivedFromTxMeta', () => { describe('getSwapsTokensReceivedFromTxMeta', () => {

14
ui/pages/swaps/swaps.util.ts
View File

@ -545,8 +545,18 @@ export function quotesToRenderableData({
}); });
} }
export function formatSwapsValueForDisplay(destinationAmount: string): string { export function formatSwapsValueForDisplay(
let amountToDisplay = toPrecisionWithoutTrailingZeros(destinationAmount, 12); destinationAmount: string | BigNumber,
): string {
let amountToDisplay;
if (
typeof destinationAmount === 'string' &&
destinationAmount.includes('...')
) {
amountToDisplay = destinationAmount;
} else {
amountToDisplay = toPrecisionWithoutTrailingZeros(destinationAmount, 12);
}
if (amountToDisplay.match(/e[+-]/u)) { if (amountToDisplay.match(/e[+-]/u)) {
amountToDisplay = new BigNumber(amountToDisplay).toFixed(); amountToDisplay = new BigNumber(amountToDisplay).toFixed();
} }