From 8c87c46601e31132dd50b7ac59879c4ed39fe836 Mon Sep 17 00:00:00 2001 From: Brad Decker Date: Thu, 22 Oct 2020 12:07:41 -0500 Subject: [PATCH] call callback func in segmentNoop.track (#9682) --- shared/modules/metametrics.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/shared/modules/metametrics.js b/shared/modules/metametrics.js index c084a7163..17b1fdd54 100644 --- a/shared/modules/metametrics.js +++ b/shared/modules/metametrics.js @@ -12,8 +12,10 @@ const flushAt = 1 export const METAMETRICS_ANONYMOUS_ID = '0x0000000000000000' const segmentNoop = { - track () { - // noop + track (_, callback = () => undefined) { + // Need to call the callback so that environments without a segment id still + // resolve the promise from trackMetaMetricsEvent + return callback() }, page () { // noop