From 8a7c897a1cd56019b594c952a56802d703a826fe Mon Sep 17 00:00:00 2001 From: ryanml Date: Tue, 31 Jan 2023 04:27:41 -0700 Subject: [PATCH] Update copy when revoking setApprovalForAll (#17500) --- app/_locales/de/messages.json | 2 +- app/_locales/el/messages.json | 2 +- app/_locales/en/messages.json | 6 +++--- app/_locales/es/messages.json | 2 +- app/_locales/fr/messages.json | 2 +- app/_locales/hi/messages.json | 2 +- app/_locales/id/messages.json | 2 +- app/_locales/ja/messages.json | 2 +- app/_locales/ko/messages.json | 2 +- app/_locales/pt/messages.json | 2 +- app/_locales/ru/messages.json | 2 +- app/_locales/tl/messages.json | 2 +- app/_locales/tr/messages.json | 2 +- app/_locales/vi/messages.json | 2 +- app/_locales/zh_CN/messages.json | 2 +- test/e2e/tests/collectibles.spec.js | 2 +- .../confirm-approve-content.component.js | 1 - 17 files changed, 18 insertions(+), 19 deletions(-) diff --git a/app/_locales/de/messages.json b/app/_locales/de/messages.json index 5a58b8d0d..96d283997 100644 --- a/app/_locales/de/messages.json +++ b/app/_locales/de/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Wenn Sie diese Erlaubnis entziehen, wird folgende/s/r $1 nicht mehr dazu in der Lage sein, auf Ihr/e/n $2 zuzugreifen.", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Ausgabengrenze für Ihr $1 aufgeben", diff --git a/app/_locales/el/messages.json b/app/_locales/el/messages.json index 9f22b1fd5..65fef7a4d 100644 --- a/app/_locales/el/messages.json +++ b/app/_locales/el/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Με την ανάκληση της άδειας, το ακόλουθο $1 δεν θα έχει πλέον πρόσβαση στο $2 σας", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Ανάκληση του ανώτατου ορίου δαπανών για το $1", diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 5870df9b4..6194fcb96 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -3085,12 +3085,12 @@ "message": "Review your spending cap" }, "revokeAllTokensTitle": { - "message": "Revoke permission to access all of your $1?", + "message": "Revoke permission to access and transfer all of your $1?", "description": "$1 is the symbol of the token for which the user is revoking approval" }, "revokeApproveForAllDescription": { - "message": "By revoking permission, the following $1 will no longer be able to access your $2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "message": "This revokes the permission for a third party to access and transfer all of your $1 without further notice.", + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Revoke spending cap for your $1", diff --git a/app/_locales/es/messages.json b/app/_locales/es/messages.json index 4105c7e1a..8da471a04 100644 --- a/app/_locales/es/messages.json +++ b/app/_locales/es/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Al revocar permisos, el/la siguiente $1 no tendrá más acceso a su $2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Revocar un límite de gasto para su $1", diff --git a/app/_locales/fr/messages.json b/app/_locales/fr/messages.json index 5e7f90ebc..d10e36caa 100644 --- a/app/_locales/fr/messages.json +++ b/app/_locales/fr/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "En révoquant cette autorisation, les $1 suivants ne pourront plus accéder à vos $2. ", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Supprimez le plafond des dépenses pour vos $1", diff --git a/app/_locales/hi/messages.json b/app/_locales/hi/messages.json index c2594d410..ca7805ebf 100644 --- a/app/_locales/hi/messages.json +++ b/app/_locales/hi/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "अनुमति निरस्त करने से, निम्नलिखित $1 अब आपके $2 को एक्सेस नहीं कर सकेगा", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "अपने $1 के लिए खर्च की सीमा को हटा दें", diff --git a/app/_locales/id/messages.json b/app/_locales/id/messages.json index 36e3fa60b..92f503797 100644 --- a/app/_locales/id/messages.json +++ b/app/_locales/id/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Dengan mencabut izin, $1 berikut tidak lagi dapat mengakses $2 Anda", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Cabut batas pengeluaran untuk $1", diff --git a/app/_locales/ja/messages.json b/app/_locales/ja/messages.json index c78f5f6d7..049663315 100644 --- a/app/_locales/ja/messages.json +++ b/app/_locales/ja/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "アクセス許可を取り消すと、次の $1 が今後 $2 にアクセスできなくなります", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "$1 の使用上限を取り消す", diff --git a/app/_locales/ko/messages.json b/app/_locales/ko/messages.json index 410bd23fb..8d7be74f7 100644 --- a/app/_locales/ko/messages.json +++ b/app/_locales/ko/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "권한을 철회하면 다음 $1(이)가 더 이상 $2에 액세스할 수 없습니다.", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "$1에 대한 지출 한도 취소", diff --git a/app/_locales/pt/messages.json b/app/_locales/pt/messages.json index f36e4e7fa..8ad0d82d0 100644 --- a/app/_locales/pt/messages.json +++ b/app/_locales/pt/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Ao revogar a permissão, o $1 a seguir não terá mais acesso ao seu $2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Revogar limite de gastos de seu $1", diff --git a/app/_locales/ru/messages.json b/app/_locales/ru/messages.json index 1f602187a..3dfa6bd13 100644 --- a/app/_locales/ru/messages.json +++ b/app/_locales/ru/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "При отмене разрешения следующий $1 больше не сможет получить доступ к вашему $2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Отменить верхний лимит расходов для вашего $1", diff --git a/app/_locales/tl/messages.json b/app/_locales/tl/messages.json index 1b672b1ec..efadef97d 100644 --- a/app/_locales/tl/messages.json +++ b/app/_locales/tl/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Sa pamamagitan ng pagbawi ng pahintulot, hindi na maa-access ng sumusunod na $1 ang iyong $2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Bawiin ang limitasyon sa paggastos para sa iyong $1", diff --git a/app/_locales/tr/messages.json b/app/_locales/tr/messages.json index 89047c1fc..668af91bd 100644 --- a/app/_locales/tr/messages.json +++ b/app/_locales/tr/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "İzni geri çektiğinizde aşağıdaki $1 artık $2 alanınıza erişim sağlayamayacak", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "$1 için harcama üst limitini iptal et", diff --git a/app/_locales/vi/messages.json b/app/_locales/vi/messages.json index 3778ecace..61315546a 100644 --- a/app/_locales/vi/messages.json +++ b/app/_locales/vi/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "Bằng cách thu hồi quyền truy cập, $1 sau đây sẽ không thể truy cập vào $2 của bạn nữa", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "Thu hồi hạn mức chi tiêu cho $1 của bạn", diff --git a/app/_locales/zh_CN/messages.json b/app/_locales/zh_CN/messages.json index 7fd51bfae..2cc589f2d 100644 --- a/app/_locales/zh_CN/messages.json +++ b/app/_locales/zh_CN/messages.json @@ -3058,7 +3058,7 @@ }, "revokeApproveForAllDescription": { "message": "通过撤销权限，以下$1将无法再访问您的$2", - "description": "$1 is either key 'account' or 'contract', and $2 is either a string or link of a given token symbol or name" + "description": "$1 is either a string or link of a given token symbol or name" }, "revokeSpendingCap": { "message": "撤销 $1 的支出上限", diff --git a/test/e2e/tests/collectibles.spec.js b/test/e2e/tests/collectibles.spec.js index 9ef28314c..71fbfa19a 100644 --- a/test/e2e/tests/collectibles.spec.js +++ b/test/e2e/tests/collectibles.spec.js @@ -252,7 +252,7 @@ describe('Collectibles', function () { ); assert.equal( await title.getText(), - 'Revoke permission to access all of your TestDappCollectibles?', + 'Revoke permission to access and transfer all of your TestDappCollectibles?', ); assert.equal(await func.getText(), 'Function: SetApprovalForAll'); assert.equal(await params.getText(), 'Parameters: false'); diff --git a/ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js b/ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js index 80644b9bc..0c4a5c6f8 100644 --- a/ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js +++ b/ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js @@ -465,7 +465,6 @@ export default class ConfirmApproveContent extends Component { if (isSetApproveForAll && isApprovalOrRejection === false) { description = t('revokeApproveForAllDescription', [ - grantee, this.getTitleTokenDescription(), ]); } else if (