m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

Fix inpage.js event handler memory leak (#6177)

Browse Source 
Fixes #6176
This commit is contained in:
Graham Kaemmer 2019-02-18 13:07:58 -08:00 committed by Paul Bouchon
parent b58a9bd202
commit 89c4353408
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/scripts/inpage.js
View File

@ -29,12 +29,13 @@ console.warn('ATTENTION: In an effort to improve user privacy, MetaMask ' +
* @param {Function} handler - event handler
* @param {boolean} remove - removes this handler after being triggered
*/
function onMessage (messageType, handler, remove) {
window.addEventListener('message', function ({ data }) {
function onMessage (messageType, callback, remove) {
const handler = function ({ data }) {
if (!data || data.type !== messageType) { return }
remove && window.removeEventListener('message', handler)
handler.apply(window, arguments)
})
callback.apply(window, arguments)
}
window.addEventListener('message', handler)
}
//