m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

notification-manager - rename show -> showPoup + make getPopup private

Browse Source
This commit is contained in:
kumavis 2017-03-31 18:41:51 -07:00
parent aa06183c64
commit 86e882c51a
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/scripts/background.js
View File

@ -147,7 +147,7 @@ function setupController (initState) {
// popup trigger // popup trigger
function triggerUi () { function triggerUi () {
if (!popupIsOpen) notificationManager.show() if (!popupIsOpen) notificationManager.showPopup()
} }
// On first install, open a window to MetaMask website to how-it-works. // On first install, open a window to MetaMask website to how-it-works.

20
app/scripts/lib/notification-manager.js
View File

@ -9,8 +9,8 @@ class NotificationManager {
// Public // Public
// //
show () { showPopup () {
this.getPopup((err, popup) => { this._getPopup((err, popup) => {
if (err) throw err if (err) throw err
if (popup) { if (popup) {
@ -31,15 +31,8 @@ class NotificationManager {
}) })
} }
getPopup (cb) {
this._getWindows((err, windows) => {
if (err) throw err
cb(null, this._getPopupIn(windows))
})
}
closePopup () { closePopup () {
this.getPopup((err, popup) => { this._getPopup((err, popup) => {
if (err) throw err if (err) throw err
if (!popup) return if (!popup) return
extension.windows.remove(popup.id, console.error) extension.windows.remove(popup.id, console.error)
@ -50,6 +43,13 @@ class NotificationManager {
// Private // Private
// //
_getPopup (cb) {
this._getWindows((err, windows) => {
if (err) throw err
cb(null, this._getPopupIn(windows))
})
}
_getWindows (cb) { _getWindows (cb) {
// Ignore in test environment // Ignore in test environment
if (!extension.windows) { if (!extension.windows) {