Merge pull request #988 from MetaMask/eth_syncing

web3 provider - override eth_syncing and web3_clientVersion

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Current Master
 
+- Fix memory leak in RPC Cache
+- Override RPC commands eth_syncing and web3_clientVersion
 - Remove certain non-essential permissions from certain builds.
 - Add a check for when a tx is included in a block.
 - Fix bug where browser-solidity would sometimes warn of a contract creation error when there was none.

app/scripts/metamask-controller.js

@@ -13,6 +13,7 @@ const extension = require('./lib/extension')
 const autoFaucet = require('./lib/auto-faucet')
 const nodeify = require('./lib/nodeify')
 const IdStoreMigrator = require('./lib/idStore-migrator')
+const version = require('../manifest.json').version
 
 module.exports = class MetamaskController extends EventEmitter {
 
@@ -175,6 +176,10 @@ module.exports = class MetamaskController extends EventEmitter {
     const keyringController = this.keyringController
 
     var providerOpts = {
+      static: {
+        eth_syncing: false,
+        web3_clientVersion: `MetaMask/v${version}`,
+      },
       rpcUrl: this.configManager.getCurrentRpcAddress(),
       // account mgmt
       getAccounts: (cb) => {