Merge pull request #217 from MetaMask/FixWarning

incorrect password after signing in

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Current Master
 
 - Added copy address button to account list.
+- Fixed bug where error warning was sometimes not cleared on view transition.
 
 ## 2.0.0 2016-05-23
 

test/unit/reducers/unlock_vault_test.js

@@ -0,0 +1,51 @@
+var jsdom = require('mocha-jsdom')
+var assert = require('assert')
+var freeze = require('deep-freeze-strict')
+var path = require('path')
+var sinon = require('sinon')
+
+var actions = require(path.join(__dirname, '..', '..', '..', 'ui', 'app', 'actions.js'))
+var reducers = require(path.join(__dirname, '..', '..',  '..', 'ui', 'app', 'reducers.js'))
+
+describe('#unlockMetamask(selectedAccount)', function() {
+
+  beforeEach(function() {
+    // sinon allows stubbing methods that are easily verified
+    this.sinon = sinon.sandbox.create()
+  })
+
+  afterEach(function() {
+    // sinon requires cleanup otherwise it will overwrite context
+    this.sinon.restore()
+  })
+
+  describe('after an error', function() {
+    it('clears warning', function() {
+      const warning = 'this is the wrong warning'
+      const account = 'foo_account'
+      const initialState = {
+        appState: {
+          warning: warning,
+        }
+      }
+
+      const resultState = reducers(initialState, actions.unlockMetamask(account))
+      assert.equal(resultState.appState.warning, null, 'warning nullified')
+    })
+  })
+
+  describe('going home after an error', function() {
+    it('clears warning', function() {
+      const warning = 'this is the wrong warning'
+      const account = 'foo_account'
+      const initialState = {
+        appState: {
+          warning: warning,
+        }
+      }
+
+      const resultState = reducers(initialState, actions.goHome())
+      assert.equal(resultState.appState.warning, null, 'warning nullified')
+    })
+  })
+})

ui/app/reducers/app.js

@@ -152,6 +152,7 @@ function reduceApp(state, action) {
         privateKey: '',
       },
       transForward: false,
+      warning: null,
     })
 
   case actions.SHOW_ACCOUNT_DETAIL: