m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-23 02:10:12 +01:00
Code

Fix inpage provider name regression

Browse Source 
Fixes #3372 by not minifying the name of our inpage provider, which some
people were using to identify MetaMask (not our preferred, supported
method of web3.currentProvider.isMetaMask).
This commit is contained in:
Dan Finlay 2018-03-02 10:32:53 -08:00
parent f22dfd4ae8
commit 81fa0742f7
4 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -2,6 +2,8 @@
## Current Master ## Current Master
- Ensure MetaMask's inpage provider is named MetamaskInpageProvider to keep some sites from breaking.
## 4.1.2 2018-2-28 ## 4.1.2 2018-2-28
- Actually includes all the fixes mentioned in 4.1.1 (sorry) - Actually includes all the fixes mentioned in 4.1.1 (sorry)

4
gulpfile.js
View File

@ -407,7 +407,9 @@ function bundleTask(opts) {
// loads map from browserify file // loads map from browserify file
.pipe(gulpif(debug, sourcemaps.init({ loadMaps: true }))) .pipe(gulpif(debug, sourcemaps.init({ loadMaps: true })))
// Minification // Minification
.pipe(gulpif(opts.isBuild, uglify())) .pipe(gulpif(opts.isBuild, uglify({
mangle: { reserved: [ 'MetamaskInpageProvider' ] },
})))
// writes .map file // writes .map file
.pipe(gulpif(debug, sourcemaps.write('./'))) .pipe(gulpif(debug, sourcemaps.write('./')))
// write completed bundles // write completed bundles

2
package.json
View File

@ -211,7 +211,7 @@
"gulp-stylefmt": "^1.1.0", "gulp-stylefmt": "^1.1.0",
"gulp-stylelint": "^4.0.0", "gulp-stylelint": "^4.0.0",
"gulp-uglify": "^3.0.0", "gulp-uglify": "^3.0.0",
"gulp-uglify-es": "^1.0.0", "gulp-uglify-es": "^1.0.1",
"gulp-util": "^3.0.7", "gulp-util": "^3.0.7",
"gulp-watch": "^5.0.0", "gulp-watch": "^5.0.0",
"gulp-zip": "^4.0.0", "gulp-zip": "^4.0.0",

6
yarn.lock
View File

@ -7348,9 +7348,9 @@ mersenne-twister@^1.0.1:
version "1.1.0" version "1.1.0"
resolved "https://registry.yarnpkg.com/mersenne-twister/-/mersenne-twister-1.1.0.tgz#f916618ee43d7179efcf641bec4531eb9670978a" resolved "https://registry.yarnpkg.com/mersenne-twister/-/mersenne-twister-1.1.0.tgz#f916618ee43d7179efcf641bec4531eb9670978a"
metamascara@^1.3.1: metamascara@^2.0.0:
version "1.3.1" version "2.2.1"
resolved "https://registry.yarnpkg.com/metamascara/-/metamascara-1.3.1.tgz#a84d6f20ef4ba401ce44eba120857ee1d680747b" resolved "https://registry.yarnpkg.com/metamascara/-/metamascara-2.2.1.tgz#f97b87045a245e1bd2e1bcae7a3d4dcd4e17c02a"
dependencies: dependencies:
iframe "^1.0.0" iframe "^1.0.0"
iframe-stream "^3.0.0" iframe-stream "^3.0.0"