m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

EIP-1559 - Only show advanced form toggle when radio buttons are present (#11713)

Browse Source
This commit is contained in:
David Walsh 2021-08-01 08:09:53 -05:00 committed by GitHub
parent 219b0f9bd6
commit 81f274303e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ui/components/app/edit-gas-display/edit-gas-display.component.js
View File

@ -80,6 +80,11 @@ export default function EditGasDisplay({
const networkSupports1559 = useSelector(isEIP1559Network); const networkSupports1559 = useSelector(isEIP1559Network);
const showTopError = balanceError; const showTopError = balanceError;
const showRadioButtons =
networkSupports1559 &&
!requireDappAcknowledgement &&
![EDIT_GAS_MODES.SPEED_UP, EDIT_GAS_MODES.CANCEL].includes(mode);
let errorKey; let errorKey;
if (balanceError) { if (balanceError) {
errorKey = 'insufficientFunds'; errorKey = 'insufficientFunds';
@ -163,9 +168,7 @@ export default function EditGasDisplay({
{t('gasDisplayAcknowledgeDappButtonText')} {t('gasDisplayAcknowledgeDappButtonText')}
</Button> </Button>
)} )}
{networkSupports1559 && {showRadioButtons && (
!requireDappAcknowledgement &&
![EDIT_GAS_MODES.SPEED_UP, EDIT_GAS_MODES.CANCEL].includes(mode) && (
<RadioGroup <RadioGroup
name="gas-recommendation" name="gas-recommendation"
options={[ options={[
@ -183,15 +186,14 @@ export default function EditGasDisplay({
{ {
value: GAS_RECOMMENDATIONS.HIGH, value: GAS_RECOMMENDATIONS.HIGH,
label: t('editGasHigh'), label: t('editGasHigh'),
recommended: recommended: defaultEstimateToUse === GAS_RECOMMENDATIONS.HIGH,
defaultEstimateToUse === GAS_RECOMMENDATIONS.HIGH,
}, },
]} ]}
selectedValue={estimateToUse} selectedValue={estimateToUse}
onChange={setEstimateToUse} onChange={setEstimateToUse}
/> />
)} )}
{!requireDappAcknowledgement && ( {!requireDappAcknowledgement && showRadioButtons && (
<button <button
className="edit-gas-display__advanced-button" className="edit-gas-display__advanced-button"
onClick={() => setShowAdvancedForm(!showAdvancedForm)} onClick={() => setShowAdvancedForm(!showAdvancedForm)}