Use eslint-plugin-react@7.18.3 (#8085)

.eslintrc.js

@@ -93,4 +93,10 @@ module.exports = {
     'babel/semi': ['error', 'never'],
     'mocha/no-setup-in-describe': 'off',
   },
+
+  settings: {
+    'react': {
+      'version': 'detect',
+    },
+  },
 }

package.json

@@ -209,7 +209,7 @@
     "eslint-plugin-import": "^2.19.1",
     "eslint-plugin-json": "^1.2.0",
     "eslint-plugin-mocha": "^6.2.2",
-    "eslint-plugin-react": "^7.4.0",
+    "eslint-plugin-react": "^7.18.3",
     "fancy-log": "^1.3.3",
     "fetch-mock": "^6.5.2",
     "file-loader": "^1.1.11",

ui/app/components/app/account-panel.js

@@ -1,8 +1,15 @@
+import PropTypes from 'prop-types'
 import React, { Component } from 'react'
 import Identicon from '../ui/identicon'
 import { addressSummary, formatBalance } from '../../helpers/utils/util'
 
 export default class AccountPanel extends Component {
+  static propTypes = {
+    identity: PropTypes.object,
+    account: PropTypes.object,
+    isFauceting: PropTypes.bool,
+  }
+
   render () {
     const state = this.props
     const identity = state.identity || {}
@@ -29,7 +36,7 @@ export default class AccountPanel extends Component {
         onClick={panelState.onClick}
       >
         <div className="identicon-wrapper flex-column select-none">
-          <Identicon address={panelState.identiconKey} imageify={state.imageifyIdenticons} />
+          <Identicon address={panelState.identiconKey} />
           <span className="font-small">{panelState.identiconLabel.substring(0, 7) + '...'}</span>
         </div>
         <div className="identity-data flex-column flex-justify-center flex-grow select-none">

ui/app/components/app/connected-sites-list/connected-sites-list.component.js

@@ -30,7 +30,7 @@ export default class ConnectedSitesList extends Component {
     expandedDomain: '',
   }
 
-  componentWillMount () {
+  UNSAFE_componentWillMount () {
     const { getOpenMetamaskTabsIds } = this.props
     getOpenMetamaskTabsIds()
   }

ui/app/components/app/dropdowns/network-dropdown.js

@@ -51,6 +51,8 @@ class NetworkDropdown extends Component {
 
   static propTypes = {
     provider: PropTypes.shape({
+      nickname: PropTypes.string,
+      rpcTarget: PropTypes.string,
       type: PropTypes.string,
       ticker: PropTypes.string,
     }).isRequired,
@@ -62,6 +64,7 @@ class NetworkDropdown extends Component {
     frequentRpcListDetail: PropTypes.array.isRequired,
     networkDropdownOpen: PropTypes.bool.isRequired,
     history: PropTypes.object.isRequired,
+    delRpcTarget: PropTypes.func.isRequired,
   }
 
   handleClick (newProviderType) {

ui/app/components/app/gas-customization/gas-modal-page-container/gas-modal-page-container.component.js

@@ -27,6 +27,8 @@ export default class GasModalPageContainer extends Component {
       originalTotalEth: PropTypes.string,
       newTotalFiat: PropTypes.string,
       newTotalEth: PropTypes.string,
+      sendAmount: PropTypes.string,
+      transactionFee: PropTypes.string,
     }),
     onSubmit: PropTypes.func,
     customModalGasPriceInHex: PropTypes.string,

ui/app/components/app/modals/confirm-remove-account/confirm-remove-account.component.js

@@ -49,6 +49,7 @@ export default class ConfirmRemoveAccount extends Component {
             className=""
             href={genAccountLink(identity.address, this.props.network)}
             target="_blank"
+            rel="noopener noreferrer"
             title={this.context.t('etherscanView')}
           >
             <img src="images/popout.svg" />

ui/app/components/app/token-cell/token-cell.component.js

@@ -11,6 +11,21 @@ export default class TokenCell extends Component {
     metricsEvent: PropTypes.func,
   }
 
+  static propTypes = {
+    address: PropTypes.string,
+    symbol: PropTypes.string,
+    string: PropTypes.string,
+    network: PropTypes.string,
+    setSelectedToken: PropTypes.func.isRequired,
+    selectedTokenAddress: PropTypes.string,
+    contractExchangeRates: PropTypes.object,
+    conversionRate: PropTypes.number,
+    hideSidebar: PropTypes.bool,
+    sidebarOpen: PropTypes.bool,
+    currentCurrency: PropTypes.string,
+    image: PropTypes.string,
+  }
+
   state = {
     tokenMenuOpen: false,
   }
@@ -46,7 +61,6 @@ export default class TokenCell extends Component {
       hideSidebar,
       sidebarOpen,
       currentCurrency,
-      // userAddress,
       image,
     } = props
     let currentTokenToFiatRate

ui/app/pages/create-account/connect-hardware/account-list.js

@@ -103,6 +103,7 @@ class AccountList extends Component {
                 className="hw-account-list__item__link"
                 href={genAccountLink(account.address, this.props.network)}
                 target="_blank"
+                rel="noopener noreferrer"
                 title={this.context.t('etherscanView')}
               >
                 <img src="images/popout.svg" alt="" />

ui/app/pages/create-account/import-account/json.js

@@ -26,7 +26,7 @@ class JsonImportSubview extends Component {
     return (
       <div className="new-account-import-form__json">
         <p>{this.context.t('usedByClients')}</p>
-        <a className="warning" href={HELP_LINK} target="_blank">{this.context.t('fileImportFail')}</a>
+        <a className="warning" href={HELP_LINK} target="_blank" rel="noopener noreferrer">{this.context.t('fileImportFail')}</a>
         <FileInput
           readAs="text"
           onLoad={this.onLoad.bind(this)}

ui/app/pages/first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js

@@ -291,7 +291,7 @@ export default class ImportWithSeedPhrase extends PureComponent {
               rel="noopener noreferrer"
             >
               <span className="first-time-flow__link-text">
-                { 'Terms of Use' }
+                { t('terms') }
               </span>
             </a>
           </span>

ui/app/pages/first-time-flow/create-password/new-account/new-account.component.js

@@ -211,7 +211,7 @@ export default class NewAccount extends PureComponent {
                 rel="noopener noreferrer"
               >
                 <span className="first-time-flow__link-text">
-                  { 'Terms of Use' }
+                  { t('terms') }
                 </span>
               </a>
             </span>

yarn.lock

@@ -3801,6 +3801,15 @@ array-includes@^3.0.3:
     define-properties "^1.1.2"
     es-abstract "^1.7.0"
 
+array-includes@^3.1.1:
+  version "3.1.1"
+  resolved "https://registry.yarnpkg.com/array-includes/-/array-includes-3.1.1.tgz#cdd67e6852bdf9c1215460786732255ed2459348"
+  integrity sha512-c2VXaCHl7zPsvpkFsw4nxvFie4fh1ur9bpcgsVkIjqn0H/Xwdg+7fv3n2r/isyS8EBj5b06M9kHyZuIr4El6WQ==
+  dependencies:
+    define-properties "^1.1.3"
+    es-abstract "^1.17.0"
+    is-string "^1.0.5"
+
 array-initial@^1.0.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/array-initial/-/array-initial-1.1.0.tgz#2fa74b26739371c3947bd7a7adc73be334b3d795"
@@ -8935,6 +8944,13 @@ doctrine@^2.0.0:
   dependencies:
     esutils "^2.0.2"
 
+doctrine@^2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-2.1.0.tgz#5cd01fc101621b42c4cd7f5d1a66243716d3f39d"
+  integrity sha512-35mSku4ZXK0vfCuHEDAwt55dg2jNajHZ1odvF+8SSr82EsZY4QmXfuWso8oEd8zRhVObSN18aM0CjSdoBX7zIw==
+  dependencies:
+    esutils "^2.0.2"
+
 doctrine@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-3.0.0.tgz#addebead72a6574db783639dc87a121773973961"
@@ -9939,15 +9955,21 @@ eslint-plugin-no-unsafe-innerhtml@1.0.16:
   dependencies:
     eslint "^3.7.1"
 
-eslint-plugin-react@^7.4.0:
+eslint-plugin-react@^7.18.3:
-  version "7.5.1"
+  version "7.18.3"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.5.1.tgz#52e56e8d80c810de158859ef07b880d2f56ee30b"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.18.3.tgz#8be671b7f6be095098e79d27ac32f9580f599bc8"
-  integrity sha512-YGSjB9Qu6QbVTroUZi66pYky3DfoIPLdHQ/wmrBGyBRnwxQsBXAov9j2rpXt/55i8nyMv6IRWJv2s4d4YnduzQ==
+  integrity sha512-Bt56LNHAQCoou88s8ViKRjMB2+36XRejCQ1VoLj716KI1MoE99HpTVvIThJ0rvFmG4E4Gsq+UgToEjn+j044Bg==
   dependencies:
-    doctrine "^2.0.0"
+    array-includes "^3.1.1"
-    has "^1.0.1"
+    doctrine "^2.1.0"
-    jsx-ast-utils "^2.0.0"
+    has "^1.0.3"
-    prop-types "^15.6.0"
+    jsx-ast-utils "^2.2.3"
+    object.entries "^1.1.1"
+    object.fromentries "^2.0.2"
+    object.values "^1.1.1"
+    prop-types "^15.7.2"
+    resolve "^1.14.2"
+    string.prototype.matchall "^4.0.2"
 
 eslint-rule-composer@^0.3.0:
   version "0.3.0"
@@ -15648,6 +15670,11 @@ is-string@^1.0.4:
   resolved "https://registry.yarnpkg.com/is-string/-/is-string-1.0.4.tgz#cc3a9b69857d621e963725a24caeec873b826e64"
   integrity sha1-zDqbaYV9Yh6WNyWiTK7shzuCbmQ=
 
+is-string@^1.0.5:
+  version "1.0.5"
+  resolved "https://registry.yarnpkg.com/is-string/-/is-string-1.0.5.tgz#40493ed198ef3ff477b8c7f92f644ec82a5cd3a6"
+  integrity sha512-buY6VNRjhQMiF1qWDouloZlQbRhDPCebwxSjxMjxgemYT46YMd2NR0/H+fBhEfWX4A/w9TBJ+ol+okqJKFE6vQ==
+
 is-subset@^0.1.1:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/is-subset/-/is-subset-0.1.1.tgz#8a59117d932de1de00f245fcdd39ce43f1e939a6"
@@ -16853,12 +16880,13 @@ jss@^9.3.3, jss@^9.7.0:
     symbol-observable "^1.1.0"
     warning "^3.0.0"
 
-jsx-ast-utils@^2.0.0:
+jsx-ast-utils@^2.2.3:
-  version "2.0.1"
+  version "2.2.3"
-  resolved "https://registry.yarnpkg.com/jsx-ast-utils/-/jsx-ast-utils-2.0.1.tgz#e801b1b39985e20fffc87b40e3748080e2dcac7f"
+  resolved "https://registry.yarnpkg.com/jsx-ast-utils/-/jsx-ast-utils-2.2.3.tgz#8a9364e402448a3ce7f14d357738310d9248054f"
-  integrity sha1-6AGxs5mF4g//yHtA43SAgOLcrH8=
+  integrity sha512-EdIHFMm+1BPynpKOpdPqiOsvnIrInRGJD7bzPZdPkjitQEqpdpUuFpq4T0npZFKTiB3RhWFdGN+oqOJIdhDhQA==
   dependencies:
     array-includes "^3.0.3"
+    object.assign "^4.1.0"
 
 jszip@^3.1.5:
   version "3.2.2"
@@ -20438,6 +20466,16 @@ object.entries@^1.1.0:
     function-bind "^1.1.1"
     has "^1.0.3"
 
+object.entries@^1.1.1:
+  version "1.1.1"
+  resolved "https://registry.yarnpkg.com/object.entries/-/object.entries-1.1.1.tgz#ee1cf04153de02bb093fec33683900f57ce5399b"
+  integrity sha512-ilqR7BgdyZetJutmDPfXCDffGa0/Yzl2ivVNpbx/g4UeWrCdRnFDUBrKJGLhGieRHDATnyZXWBeCb29k9CJysQ==
+  dependencies:
+    define-properties "^1.1.3"
+    es-abstract "^1.17.0-next.1"
+    function-bind "^1.1.1"
+    has "^1.0.3"
+
 "object.fromentries@^2.0.0 || ^1.0.0":
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/object.fromentries/-/object.fromentries-2.0.0.tgz#49a543d92151f8277b3ac9600f1e930b189d30ab"
@@ -20458,6 +20496,16 @@ object.fromentries@^2.0.1:
     function-bind "^1.1.1"
     has "^1.0.3"
 
+object.fromentries@^2.0.2:
+  version "2.0.2"
+  resolved "https://registry.yarnpkg.com/object.fromentries/-/object.fromentries-2.0.2.tgz#4a09c9b9bb3843dd0f89acdb517a794d4f355ac9"
+  integrity sha512-r3ZiBH7MQppDJVLx6fhD618GKNG40CZYH9wgwdhKxBDDbQgjeWGGd4AtkZad84d291YxvWe7bJGuE65Anh0dxQ==
+  dependencies:
+    define-properties "^1.1.3"
+    es-abstract "^1.17.0-next.1"
+    function-bind "^1.1.1"
+    has "^1.0.3"
+
 object.getownpropertydescriptors@^2.0.3:
   version "2.0.3"
   resolved "https://registry.yarnpkg.com/object.getownpropertydescriptors/-/object.getownpropertydescriptors-2.0.3.tgz#8758c846f5b407adab0f236e0986f14b051caa16"
@@ -20525,6 +20573,16 @@ object.values@^1.1.0:
     function-bind "^1.1.1"
     has "^1.0.3"
 
+object.values@^1.1.1:
+  version "1.1.1"
+  resolved "https://registry.yarnpkg.com/object.values/-/object.values-1.1.1.tgz#68a99ecde356b7e9295a3c5e0ce31dc8c953de5e"
+  integrity sha512-WTa54g2K8iu0kmS/us18jEmdv1a4Wi//BZ/DTVYEcH0XhLM5NYdpDHja3gt57VrZLcNAO2WGA+KpWsDBaHt6eA==
+  dependencies:
+    define-properties "^1.1.3"
+    es-abstract "^1.17.0-next.1"
+    function-bind "^1.1.1"
+    has "^1.0.3"
+
 oboe@2.1.4:
   version "2.1.4"
   resolved "https://registry.yarnpkg.com/oboe/-/oboe-2.1.4.tgz#20c88cdb0c15371bb04119257d4fdd34b0aa49f6"
@@ -24442,7 +24500,7 @@ resolve@1.3.2:
   dependencies:
     path-parse "^1.0.5"
 
-resolve@^1.1.4, resolve@^1.1.5, resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.11.0, resolve@^1.11.1, resolve@^1.12.0, resolve@^1.3.2, resolve@^1.4.0, resolve@^1.5.0, resolve@^1.8.1:
+resolve@^1.1.4, resolve@^1.1.5, resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.11.0, resolve@^1.11.1, resolve@^1.12.0, resolve@^1.14.2, resolve@^1.3.2, resolve@^1.4.0, resolve@^1.5.0, resolve@^1.8.1:
   version "1.15.1"
   resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.15.1.tgz#27bdcdeffeaf2d6244b95bb0f9f4b4653451f3e8"
   integrity sha512-84oo6ZTtoTUpjgNEr5SJyzQhzL72gaRodsSfyxC/AXRvwu0Yse9H8eF9IpGo7b8YetZhlI6v7ZQ6bKBFV/6S7w==