From 80437b9b4aeb544951216cfedb6536a0b859c87b Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Tue, 23 May 2023 11:46:45 +0200 Subject: [PATCH] [FLASK] Fix an issue with submitting an empty Snaps UI prompt (#19227) * Fix an issue with submitting an empty Snaps UI prompt * Fix code fencing * Revert accidental whitespace change --- ui/pages/confirmation/confirmation.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/pages/confirmation/confirmation.js b/ui/pages/confirmation/confirmation.js index 4a3c47b50..44f661f3c 100644 --- a/ui/pages/confirmation/confirmation.js +++ b/ui/pages/confirmation/confirmation.js @@ -11,7 +11,9 @@ import { useHistory } from 'react-router-dom'; import { isEqual } from 'lodash'; import { produce } from 'immer'; +///: BEGIN:ONLY_INCLUDE_IN(snaps) import { ApprovalType } from '@metamask/controller-utils'; +///: END:ONLY_INCLUDE_IN import Box from '../../components/ui/box'; import MetaMaskTemplateRenderer from '../../components/app/metamask-template-renderer'; import ConfirmationWarningModal from '../../components/app/confirmation-warning-modal'; @@ -275,6 +277,10 @@ export default function ConfirmationPage({ return INPUT_STATE_CONFIRMATIONS.includes(type); }; + const getInputState = (type) => { + return inputStates[type] ?? ''; + }; + const handleSubmitResult = (submitResult) => { if (submitResult?.length > 0) { setLoadingText(templatedValues.submitText); @@ -290,7 +296,7 @@ export default function ConfirmationPage({ setShowWarningModal(true); } else { const inputState = hasInputState(pendingConfirmation.type) - ? inputStates[ApprovalType.SnapDialogPrompt] + ? getInputState(pendingConfirmation.type) : null; // submit result is an array of errors or empty on success const submitResult = await templatedValues.onSubmit(inputState);