Simplify tab component (#8132)

The tab component now sets the `tab` and `tab--active` classes
internally regardless what class is passed in. The convention in React
is to allow adding _additional_ classes via the `className` prop, not
to allow removing internal classes entirely.

the `activeClassName` prop was removed entirely. A few other props that
are always passed in have been marked as required.

ui/app/components/ui/tabs/tab/tab.component.js

@@ -3,13 +3,14 @@ import PropTypes from 'prop-types'
 import classnames from 'classnames'
 
 const Tab = (props) => {
-  const { name, onClick, isActive, tabIndex, className, activeClassName } = props
+  const { name, onClick, isActive, tabIndex, className } = props
 
   return (
     <li
       className={classnames(
+        'tab',
         className,
-        { [activeClassName]: isActive },
+        { 'tab--active': isActive },
       )}
       onClick={(event) => {
         event.preventDefault()
@@ -22,17 +23,16 @@ const Tab = (props) => {
 }
 
 Tab.propTypes = {
+  className: PropTypes.string,
+  isActive: PropTypes.bool.isRequired,
   name: PropTypes.string.isRequired,
   onClick: PropTypes.func,
-  isActive: PropTypes.bool,
+  tabIndex: PropTypes.number.isRequired,
-  tabIndex: PropTypes.number,
-  className: PropTypes.string,
-  activeClassName: PropTypes.string,
 }
 
 Tab.defaultProps = {
-  className: 'tab',
+  className: undefined,
-  activeClassName: 'tab--active',
+  onClick: undefined,
 }
 
 export default Tab