m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

remove siwe feature flag (#17690)

Browse Source 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
This commit is contained in:
Sam Gbafa 2023-02-09 11:05:16 -08:00 committed by GitHub
parent 0c2af508ef
commit 7aad1c9650
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.metamaskrc.dist
View File

@ -9,8 +9,5 @@ PUBNUB_SUB_KEY=
PORTFOLIO_URL= PORTFOLIO_URL=
TRANSACTION_SECURITY_PROVIDER= TRANSACTION_SECURITY_PROVIDER=
; Set this to '1' to enable support for Sign-In with Ethereum [EIP-4361](https://eips.ethereum.org/EIPS/eip-4361)
SIWE_V1=
; Set this to test changes to the phishing warning page. ; Set this to test changes to the phishing warning page.
PHISHING_WARNING_PAGE_URL= PHISHING_WARNING_PAGE_URL=

4
app/scripts/lib/createRPCMethodTrackingMiddleware.js
View File

@ -166,7 +166,7 @@ export default function createRPCMethodTrackingMiddleware({
properties.method = method; properties.method = method;
} }
if (process.env.SIWE_V1 && method === MESSAGE_TYPE.PERSONAL_SIGN) { if (method === MESSAGE_TYPE.PERSONAL_SIGN) {
const data = req?.params?.[0]; const data = req?.params?.[0];
const { isSIWEMessage } = detectSIWE({ data }); const { isSIWEMessage } = detectSIWE({ data });
if (isSIWEMessage) { if (isSIWEMessage) {
@ -208,7 +208,7 @@ export default function createRPCMethodTrackingMiddleware({
properties.method = method; properties.method = method;
} }
if (process.env.SIWE_V1 && method === MESSAGE_TYPE.PERSONAL_SIGN) { if (method === MESSAGE_TYPE.PERSONAL_SIGN) {
const data = req?.params?.[0]; const data = req?.params?.[0];
const { isSIWEMessage } = detectSIWE({ data }); const { isSIWEMessage } = detectSIWE({ data });
if (isSIWEMessage) { if (isSIWEMessage) {

1
development/build/config.js
View File

@ -14,7 +14,6 @@ const configurationPropertyNames = [
'SEGMENT_HOST', 'SEGMENT_HOST',
'SEGMENT_WRITE_KEY', 'SEGMENT_WRITE_KEY',
'SENTRY_DSN_DEV', 'SENTRY_DSN_DEV',
'SIWE_V1',
'SWAPS_USE_DEV_APIS', 'SWAPS_USE_DEV_APIS',
]; ];

1
development/build/scripts.js
View File

@ -1123,7 +1123,6 @@ async function getEnvironmentVariables({ buildTarget, buildType, version }) {
SEGMENT_WRITE_KEY: getSegmentWriteKey({ buildType, config, environment }), SEGMENT_WRITE_KEY: getSegmentWriteKey({ buildType, config, environment }),
SENTRY_DSN: config.SENTRY_DSN, SENTRY_DSN: config.SENTRY_DSN,
SENTRY_DSN_DEV: config.SENTRY_DSN_DEV, SENTRY_DSN_DEV: config.SENTRY_DSN_DEV,
SIWE_V1: config.SIWE_V1 === '1',
SWAPS_USE_DEV_APIS: config.SWAPS_USE_DEV_APIS === '1', SWAPS_USE_DEV_APIS: config.SWAPS_USE_DEV_APIS === '1',
TOKEN_ALLOWANCE_IMPROVEMENTS: config.TOKEN_ALLOWANCE_IMPROVEMENTS === '1', TOKEN_ALLOWANCE_IMPROVEMENTS: config.TOKEN_ALLOWANCE_IMPROVEMENTS === '1',
TRANSACTION_SECURITY_PROVIDER: config.TRANSACTION_SECURITY_PROVIDER === '1', TRANSACTION_SECURITY_PROVIDER: config.TRANSACTION_SECURITY_PROVIDER === '1',

2
ui/pages/confirm-signature-request/index.js
View File

@ -35,7 +35,7 @@ const signatureSelect = (txData) => {
return SignatureRequest; return SignatureRequest;
} }
if (process.env.SIWE_V1 && siwe?.isSIWEMessage) { if (siwe?.isSIWEMessage) {
return SignatureRequestSIWE; return SignatureRequestSIWE;
} }