m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-11-22 09:57:02 +01:00
Code

show asset name instead of symbol for setApprovalForAll calls on NFT contracts where possible (#15296)

Browse Source
This commit is contained in:
Alex Donesky 2022-07-20 13:42:57 -05:00 committed by GitHub
parent 6233ed414d
commit 78b32153f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ui/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js
View File

@ -457,6 +457,7 @@ export default class ConfirmApproveContent extends Component {
chainId, chainId,
assetStandard, assetStandard,
tokenSymbol, tokenSymbol,
isSetApproveForAll,
} = this.props; } = this.props;
const { t } = this.context; const { t } = this.context;
let titleTokenDescription = t('token'); let titleTokenDescription = t('token');
@ -483,7 +484,10 @@ export default class ConfirmApproveContent extends Component {
titleTokenDescription = unknownTokenLink; titleTokenDescription = unknownTokenLink;
} }
if (assetStandard === ERC20 || (tokenSymbol && !tokenId)) { if (
assetStandard === ERC20 ||
(tokenSymbol && !tokenId && !isSetApproveForAll)
) {
titleTokenDescription = tokenSymbol; titleTokenDescription = tokenSymbol;
} else if ( } else if (
assetStandard === ERC721 || assetStandard === ERC721 ||
@ -492,9 +496,9 @@ export default class ConfirmApproveContent extends Component {
(assetName && tokenId) || (assetName && tokenId) ||
(tokenSymbol && tokenId) (tokenSymbol && tokenId)
) { ) {
const tokenIdWrapped = tokenId ? ` (#${tokenId})` : null; const tokenIdWrapped = tokenId ? ` (#${tokenId})` : '';
if (assetName || tokenSymbol) { if (assetName || tokenSymbol) {
titleTokenDescription = `${assetName ?? tokenSymbol} ${tokenIdWrapped}`; titleTokenDescription = `${assetName ?? tokenSymbol}${tokenIdWrapped}`;
} else { } else {
const unknownNFTBlockExplorerLink = getTokenTrackerLink( const unknownNFTBlockExplorerLink = getTokenTrackerLink(
tokenAddress, tokenAddress,