m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Prevent redux state mutation (#7598)

Browse Source 
The `txParams` property of a transaction in Redux state was being
mutated. The mutation is now prevented with a shallow clone.
This commit is contained in:
Mark Stacey 2019-11-28 18:59:15 -04:00
parent ff6b254a9b
commit 77449923c3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/app/ducks/metamask/metamask.js
View File

@ -322,7 +322,9 @@ function reduceMetamask (state, action) {
let { selectedAddressTxList } = metamaskState let { selectedAddressTxList } = metamaskState
selectedAddressTxList = selectedAddressTxList.map(tx => { selectedAddressTxList = selectedAddressTxList.map(tx => {
if (tx.id === txId) { if (tx.id === txId) {
tx.txParams = value const newTx = Object.assign({}, tx)
newTx.txParams = value
return newTx
} }
return tx return tx
}) })