m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Hide loading indication after personal_sign (#9006)

Browse Source 
The loading indication had remained after successfully signing with
`personal_sign`. This mistake was introduced accidentally in #8434.

This is noticeable if you confirm the signature in the popup UI or
fullscreen UI, as they remain open after signing. The notification UI
closes after signing without waiting for this loading indicator to be
removed.
This commit is contained in:
Mark Stacey 2020-07-15 22:12:56 -03:00 committed by GitHub
parent acaa648779
commit 7333d821b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ui/app/store/actions.js
View File

@ -475,6 +475,7 @@ export function signPersonalMsg (msgData) {
dispatch(displayWarning(error.message)) dispatch(displayWarning(error.message))
throw error throw error
} }
dispatch(hideLoadingIndication())
dispatch(updateMetamaskState(newState)) dispatch(updateMetamaskState(newState))
dispatch(completedTx(msgData.metamaskId)) dispatch(completedTx(msgData.metamaskId))
dispatch(closeCurrentNotificationWindow()) dispatch(closeCurrentNotificationWindow())