m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Return Promise from removeFromAddressBook thunk (#8451)

Browse Source 
`removeFromAddressBook` returned a thunk that didn't return a Promise,
despite doing async work. It now returns a Promise.

The callers were updated to `await` the completion of this operation.
This commit is contained in:
Mark Stacey 2020-04-29 09:36:10 -03:00 committed by GitHub
parent e20ca4668e
commit 7302a14341
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/app/pages/settings/contact-list-tab/edit-contact/edit-contact.component.js
View File

@ -49,8 +49,8 @@ export default class EditContact extends PureComponent {
<Button <Button
type="link" type="link"
className="settings-page__address-book-button" className="settings-page__address-book-button"
onClick={() => { onClick={async () => {
removeFromAddressBook(chainId, address) await removeFromAddressBook(chainId, address)
history.push(listRoute) history.push(listRoute)
}} }}
> >
@ -115,7 +115,7 @@ export default class EditContact extends PureComponent {
if (this.state.newAddress !== '' && this.state.newAddress !== address) { if (this.state.newAddress !== '' && this.state.newAddress !== address) {
// if the user makes a valid change to the address field, remove the original address // if the user makes a valid change to the address field, remove the original address
if (isValidAddress(this.state.newAddress)) { if (isValidAddress(this.state.newAddress)) {
removeFromAddressBook(chainId, address) await removeFromAddressBook(chainId, address)
await addToAddressBook(this.state.newAddress, this.state.newName || name, this.state.newMemo || memo) await addToAddressBook(this.state.newAddress, this.state.newName || name, this.state.newMemo || memo)
setAccountLabel(this.state.newAddress, this.state.newName || name) setAccountLabel(this.state.newAddress, this.state.newName || name)
history.push(listRoute) history.push(listRoute)

4
ui/app/store/actions.js
View File

@ -1551,8 +1551,8 @@ export function addToAddressBook (recipient, nickname = '', memo = '') {
export function removeFromAddressBook (chainId, addressToRemove) { export function removeFromAddressBook (chainId, addressToRemove) {
log.debug(`background.removeFromAddressBook`) log.debug(`background.removeFromAddressBook`)
return () => { return async () => {
background.removeFromAddressBook(chainId, checksumAddress(addressToRemove)) await promisifiedBackground.removeFromAddressBook(chainId, checksumAddress(addressToRemove))
} }
} }