m/metamask-extension
1
0
Fork 0
mirror of https://github.com/kremalicious/metamask-extension.git synced 2024-12-23 09:52:26 +01:00
Code

Catch reverse resolve ENS errors (#7377)

Browse Source 
The 'reverseResolveAddress' method is intended to return undefined if
unable to reverse resolve the given address. Instead it was throwing an
error, which surfaced in the UI console. This error is now caught.
This commit is contained in:
Mark Stacey 2019-11-10 21:15:59 -05:00 committed by GitHub
parent 66187333b1
commit 728115171e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/scripts/controllers/ens/index.js
View File

@ -1,6 +1,7 @@
const ethUtil = require('ethereumjs-util') const ethUtil = require('ethereumjs-util')
const ObservableStore = require('obs-store') const ObservableStore = require('obs-store')
const punycode = require('punycode') const punycode = require('punycode')
const log = require('loglevel')
const Ens = require('./ens') const Ens = require('./ens')
const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000' const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000'
@ -51,8 +52,22 @@ class EnsController {
return state.ensResolutionsByAddress[address] return state.ensResolutionsByAddress[address]
} }
const domain = await this._ens.reverse(address) let domain
const registeredAddress = await this._ens.lookup(domain) try {
domain = await this._ens.reverse(address)
} catch (error) {
log.debug(error)
return undefined
}
let registeredAddress
try {
registeredAddress = await this._ens.lookup(domain)
} catch (error) {
log.debug(error)
return undefined
}
if (registeredAddress === ZERO_ADDRESS || registeredAddress === ZERO_X_ERROR_ADDRESS) { if (registeredAddress === ZERO_ADDRESS || registeredAddress === ZERO_X_ERROR_ADDRESS) {
return undefined return undefined
} }